Replace ScrollView with NestedScrollView in sync settings - #9424
Open
MiSikora wants to merge 36 commits into
Open
Replace ScrollView with NestedScrollView in sync settings#9424MiSikora wants to merge 36 commits into
MiSikora wants to merge 36 commits into
Conversation
This was referenced Aug 7, 2026
Contributor
Author
CDRussell
approved these changes
Aug 7, 2026
MiSikora
force-pushed
the
feature/mehow/simple-sync/text-copies
branch
from
August 7, 2026 08:24
6d39974 to
80f945e
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/improve-fling
branch
from
August 7, 2026 08:24
9fcd4ac to
a8611e3
Compare
Translate strings-duckchat to values-hr
Translate strings-sync to values-hr
Translate strings-sync to values-tr
RecyclerView inside ScrollView has an issue with dispatching fling motion. When the touch point is inside a RecyclerView the fling gesture ends abruptly and doesn't dispatch scroll data to ScrollView. Propagation to NestedScrollView works correctly
MiSikora
force-pushed
the
feature/mehow/simple-sync/improve-fling
branch
from
August 7, 2026 09:46
a8611e3 to
459e96e
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/text-copies
branch
from
August 7, 2026 09:46
80f945e to
96a6c87
Compare
Contributor
Author
Merge activity
|
MiSikora
changed the base branch from
feature/mehow/simple-sync/text-copies
to
graphite-base/9424
August 7, 2026 11:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1217243919899683?focus=true
Tech Design URL (if applicable): N/A
API Proposals URL(s) (if applicable): N/A
Description
Replaces the
ScrollViewin the simplified Sync settings screen with aNestedScrollView. This gives the screen smoother scrolling and fling behavior, and lets it cooperate with nested scrolling containers.Steps to test this PR
Scroll and fling the simplified Sync settings screen
UI changes
before.mp4
after.mp4
Note
Low Risk
Single layout widget swap with no logic or API changes; low risk confined to scroll behavior on one settings screen.
Overview
The simplified Sync settings layout (
activity_sync_v2.xml) now usesandroidx.core.widget.NestedScrollViewinstead ofScrollViewforcontentScrollView, with the same id and scrollbar attributes.This targets smoother scrolling and fling behavior on Sync & Backup, especially when gestures start from nested UI such as the
devicesRecyclerlist insideview_sync_v2_enabled.Reviewed by Cursor Bugbot for commit 459e96e. Bugbot is set up for automated code reviews on this repo. Configure here.