Skip to content

Refactor simplified sync class names - #9329

Merged
MiSikora merged 2 commits into
developfrom
feature/mehow/simple-sync/name-refactor
Jul 30, 2026
Merged

Refactor simplified sync class names#9329
MiSikora merged 2 commits into
developfrom
feature/mehow/simple-sync/name-refactor

Conversation

@MiSikora

@MiSikora MiSikora commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1216955858261380
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1216103556496795/task/1216509582049467
API Proposals URL(s) (if applicable): N/A

Description

Renames the classes and resources of the simplified sync setup flow so that names describe what each screen does instead of the underlying code exchange mechanism. After working with the feature for a while I have a better understanding of the structure and the flow, and these names reflect that understanding. This is a pure refactor, there are no behavior changes.

Show QR code screen:

  • QrCodeActivity is now DisplayQrCodeActivity.
  • QrCodeContract is now DisplayQrCodeContract.
  • SyncExchangeViewModel is now DisplayQrCodeViewModel.

Read sync code screen:

  • CodeExchangeActivity is now ReadSyncCodeActivity.
  • CodeExchangeContract is now ReadSyncCodeContract.
  • CameraScannerFragment is now ReadSyncCodeCameraFragment.
  • IntroAnimationViewModel is now ReadSyncCodeCameraIntroViewModel.
  • ManualCodeEntryFragment is now ReadSyncCodeManualFragment.

Shared header view:

  • CodeExchangeHeaderView is now SyncPairingHeaderView.

Resources:

  • Layout files, generated view bindings, background drawables, view IDs, and the styleable follow the new class names.
  • Resources shared with the existing sync UI are left untouched.

Steps to test this PR

QA optional.

UI changes

N/A


Note

Low Risk
Rename-only refactor across sync v2 UI with manifest and theming string updates; no logic or pairing flow changes.

Overview
Renames the sync v2 simplified pairing UI so names match what each screen does (read vs show a code), not the old “code exchange” framing. No behavior changes.

Show QR: QrCodeActivity / QrCodeContract / SyncExchangeViewModelDisplayQrCodeActivity, DisplayQrCodeContract, DisplayQrCodeViewModel.

Read code: CodeExchangeActivity / CodeExchangeContractReadSyncCodeActivity, ReadSyncCodeContract; camera tab pieces → ReadSyncCodeCameraFragment, ReadSyncCodeCameraIntroViewModel, ReadSyncCodeManualFragment.

Shared UI: CodeExchangeHeaderViewSyncPairingHeaderView with matching layout, styleable, and drawable names (background_read_sync_code_*).

AndroidManifest, Theming fixed-theme activity list, and SyncActivity entry (readSyncCodeLauncher / ReadSyncCodeContract) are updated to the new classes. Unit tests are renamed to follow the view models.

Reviewed by Cursor Bugbot for commit 79ef2b0. Bugbot is set up for automated code reviews on this repo. Configure here.

@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/name-refactor branch from 251bad1 to d2229ec Compare July 29, 2026 07:36

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d2229ec. Configure here.

Comment thread sync/sync-impl/src/main/AndroidManifest.xml
@MiSikora MiSikora mentioned this pull request Jul 29, 2026
13 tasks
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/show-code-logic branch from d88f3c2 to 1ab2e28 Compare July 29, 2026 10:05
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/name-refactor branch from 2a2937b to bfdca0b Compare July 29, 2026 10:05
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/name-refactor branch from bfdca0b to 9d2969f Compare July 29, 2026 12:20

MiSikora commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

@MiSikora
MiSikora changed the base branch from feature/mehow/simple-sync/show-code-logic to graphite-base/9329 July 30, 2026 11:12
@MiSikora
MiSikora force-pushed the graphite-base/9329 branch from b074d48 to fb05324 Compare July 30, 2026 12:10
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/name-refactor branch from 9d2969f to 5d273c7 Compare July 30, 2026 12:10
@MiSikora
MiSikora changed the base branch from graphite-base/9329 to feature/mehow/simple-sync/show-code-logic July 30, 2026 12:10
@MiSikora
MiSikora changed the base branch from feature/mehow/simple-sync/show-code-logic to graphite-base/9329 July 30, 2026 12:31
@MiSikora
MiSikora changed the base branch from graphite-base/9329 to develop July 30, 2026 12:32
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/name-refactor branch from 5d273c7 to 79ef2b0 Compare July 30, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants