Refactor simplified sync class names - #9329
Merged
Merged
Conversation
This was referenced Jul 29, 2026
Contributor
Author
26 tasks
MiSikora
force-pushed
the
feature/mehow/simple-sync/name-refactor
branch
from
July 29, 2026 07:36
251bad1 to
d2229ec
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d2229ec. Configure here.
MiSikora
force-pushed
the
feature/mehow/simple-sync/show-code-logic
branch
from
July 29, 2026 10:05
d88f3c2 to
1ab2e28
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/name-refactor
branch
from
July 29, 2026 10:05
2a2937b to
bfdca0b
Compare
This was referenced Jul 29, 2026
MiSikora
force-pushed
the
feature/mehow/simple-sync/name-refactor
branch
from
July 29, 2026 12:20
bfdca0b to
9d2969f
Compare
This was referenced Jul 29, 2026
CDRussell
approved these changes
Jul 30, 2026
Contributor
Author
Merge activity
|
MiSikora
changed the base branch from
feature/mehow/simple-sync/show-code-logic
to
graphite-base/9329
July 30, 2026 11:12
MiSikora
force-pushed
the
graphite-base/9329
branch
from
July 30, 2026 12:10
b074d48 to
fb05324
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/name-refactor
branch
from
July 30, 2026 12:10
9d2969f to
5d273c7
Compare
MiSikora
changed the base branch from
graphite-base/9329
to
feature/mehow/simple-sync/show-code-logic
July 30, 2026 12:10
MiSikora
changed the base branch from
feature/mehow/simple-sync/show-code-logic
to
graphite-base/9329
July 30, 2026 12:31
MiSikora
force-pushed
the
feature/mehow/simple-sync/name-refactor
branch
from
July 30, 2026 12:33
5d273c7 to
79ef2b0
Compare
This was referenced Jul 31, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1216955858261380
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1216103556496795/task/1216509582049467
API Proposals URL(s) (if applicable): N/A
Description
Renames the classes and resources of the simplified sync setup flow so that names describe what each screen does instead of the underlying code exchange mechanism. After working with the feature for a while I have a better understanding of the structure and the flow, and these names reflect that understanding. This is a pure refactor, there are no behavior changes.
Show QR code screen:
QrCodeActivityis nowDisplayQrCodeActivity.QrCodeContractis nowDisplayQrCodeContract.SyncExchangeViewModelis nowDisplayQrCodeViewModel.Read sync code screen:
CodeExchangeActivityis nowReadSyncCodeActivity.CodeExchangeContractis nowReadSyncCodeContract.CameraScannerFragmentis nowReadSyncCodeCameraFragment.IntroAnimationViewModelis nowReadSyncCodeCameraIntroViewModel.ManualCodeEntryFragmentis nowReadSyncCodeManualFragment.Shared header view:
CodeExchangeHeaderViewis nowSyncPairingHeaderView.Resources:
Steps to test this PR
QA optional.
UI changes
N/A
Note
Low Risk
Rename-only refactor across sync v2 UI with manifest and theming string updates; no logic or pairing flow changes.
Overview
Renames the sync v2 simplified pairing UI so names match what each screen does (read vs show a code), not the old “code exchange” framing. No behavior changes.
Show QR:
QrCodeActivity/QrCodeContract/SyncExchangeViewModel→DisplayQrCodeActivity,DisplayQrCodeContract,DisplayQrCodeViewModel.Read code:
CodeExchangeActivity/CodeExchangeContract→ReadSyncCodeActivity,ReadSyncCodeContract; camera tab pieces →ReadSyncCodeCameraFragment,ReadSyncCodeCameraIntroViewModel,ReadSyncCodeManualFragment.Shared UI:
CodeExchangeHeaderView→SyncPairingHeaderViewwith matching layout, styleable, and drawable names (background_read_sync_code_*).AndroidManifest,Themingfixed-theme activity list, andSyncActivityentry (readSyncCodeLauncher/ReadSyncCodeContract) are updated to the new classes. Unit tests are renamed to follow the view models.Reviewed by Cursor Bugbot for commit 79ef2b0. Bugbot is set up for automated code reviews on this repo. Configure here.