Add simplified sync pixels - #9401
Open
MiSikora wants to merge 2 commits into
Open
Conversation
This was referenced Aug 5, 2026
Contributor
Author
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1217193904757982 |
MiSikora
changed the base branch from
feature/msikora/simple-sync/pixels-cleanup
to
graphite-base/9401
August 5, 2026 15:26
MiSikora
force-pushed
the
graphite-base/9401
branch
from
August 5, 2026 15:41
b109e98 to
b83ea32
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/pixels
branch
from
August 5, 2026 15:41
f70f693 to
872f15a
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/pixels
branch
from
August 5, 2026 15:42
872f15a to
7a959b3
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/pixels
branch
from
August 5, 2026 16:16
7a959b3 to
f8b12f6
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f8b12f6. Configure here.
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1216422585541219?focus=true
Tech Design URL (if applicable): N/A
API Proposals URL(s) (if applicable): N/A
Description
Brings the simplified Sync (v2) setup flow to pixel parity with the legacy setup flow and with iOS, adds a set of new Sync settings pixels, and tags sync setup pixels with a
ui_versionparameter so each pixel records whether it came from the simplified or the legacy UI. It also changes one setup behavior so restoring a previous session reuses the current device (this is the legacy behavior).New Sync settings pixels:
m_settings_sync_open.m_settings_sync_back_up_this_device_tapped.m_settings_sync_recover_synced_data_tapped.m_settings_sync_recovery_confirmed_tapped.m_settings_sync_another_device_prompt_shownwhen it appears.m_settings_sync_another_device_prompt_option_tapped, with anoptionofthis_device_onlyorsync_another_device.Simplified Sync setup parity:
sync_setup_scan_qr_screen_shown), the barcode and manual code screens shown, code recognized success and failure, setup finished, setup failed, and setup abandoned.sync_loginpixel is fired on every successful setup.ui_versionparameter:ui_versionparameter, set tov2when the simplified sync UI is enabled (useSimplifiedSync) andv1otherwise.sync-setupwide event carries the sameui_versionvalue in its metadata.Behavior change:
Note
I added only some basic tests that verify the
ui_versionparameter. I'll expand them in a followup PR after adding TestParameterInjector.Steps to test this PR
I think there are too many pixels to write a comprehensive testing scenario. I documented Pixels for the simplified UI in this task. I tested it in the following way:
useSimplifiedSyncfeature flag enabled.useSimplifiedSyncfeature flag disabled.adb -s <DEVICE_ID> logcat -s RxBasedPixel:Vin each pane.UI changes
N/A
Note
Low Risk
Changes are mostly telemetry definitions and pixel firing in sync setup UI; the only functional change is passing a preserved device id on session restore, which aligns with legacy behavior and is localized to sync account processing.
Overview
Adds analytics parity for the simplified Sync setup UI and new Sync settings telemetry, plus a small restore behavior fix.
ui_versionon sync pixels: Setup, login, signup, errors, account switching, and auto-restore events now includeui_version(v1/v2fromuseSimplifiedSync). Thesync-setupwide event adds the same field in metadata.New settings pixels: Definitions and firing for opening Sync settings, backup-this-device, recover-data taps/confirmations, and the “this device vs another device” prompt (shown + option tapped).
Simplified flow pixel wiring: v2 screens and
ProcessSyncCodeViewModelnow emit the setup pixels that legacy already had (scan QR shown, parse success/failure, finished/failed/abandoned, deep link lifecycle, account switch, auto-restore success/failure,sync_login).SyncCodeSourcereplaces raw code strings in contracts so scan/paste/deep link/restored paths are distinguished for pixels and restore logic.Restore behavior: Restoring a previous session passes the preserved device id from auto-restore payload into
processCodeso the existing device record is reused.Reviewed by Cursor Bugbot for commit 1e1965f. Bugbot is set up for automated code reviews on this repo. Configure here.