Handle sync code pasting - #9332
Conversation
6c0db36 to
c7f3a61
Compare
2a2937b to
bfdca0b
Compare
bfdca0b to
9d2969f
Compare
c7f3a61 to
85f0042
Compare
Merge activity
|
df99fd8 to
6284013
Compare
9d2969f to
5d273c7
Compare
6284013 to
fc63823
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fc63823. Configure here.
| <activity | ||
| android:name=".ui.v2.ExchangeSyncCodeActivity" | ||
| android:exported="false" | ||
| android:label="@string/sync_scanner_v2_qr_code_screen_title" |
There was a problem hiding this comment.
Manifest label is wrong copy-paste from QR activity
Low Severity
ExchangeSyncCodeActivity uses android:label="@string/sync_scanner_v2_qr_code_screen_title" which resolves to "QR Code". This was clearly copy-pasted from the DisplayQrCodeActivity entry directly above it. The label appears in the system task manager/recent apps and doesn't reflect what this activity actually does (sync code exchange).
Reviewed by Cursor Bugbot for commit fc63823. Configure here.
There was a problem hiding this comment.
I'll fix that in the upper branches of the stack



Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1216955858261368?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1216103556496795/task/1216509582049467?focus=true
API Proposals URL(s) (if applicable): N/A
Description
Adds the manual code entry UI to the "Enter Code" tab of the simplified Sync With Another Device screen.
SyncAnotherDeviceActivity.Steps to test this PR
Paste a valid sync code
UI changes
Note
Medium Risk
Touches sync pairing entry and clipboard handling on a security-sensitive path; real pairing is still stubbed, but pasted content is passed forward without validation in this change.
Overview
The Enter Code tab on Sync With Another Device is no longer a stub: it shows pairing instructions, an example sync code, and a Paste Sync Code button wired through
ReadSyncCodeViewModeland shared activity-scoped commands.Paste Sync Code reads the clipboard and emits
StartSyncProcess;ReadSyncCodeActivitylaunches the newExchangeSyncCodeActivityviaExchangeSyncCodeContractand finishes the read-sync screen when that flow returns.ExchangeSyncCodeActivityis a temporary placeholder (magenta background, pasted URL text) registered in the manifest.Strings for manual entry and an invalid-paste message are added; the diff does not wire validation or show the invalid message on paste.
Reviewed by Cursor Bugbot for commit fc63823. Bugbot is set up for automated code reviews on this repo. Configure here.