Apply correct edge to edge handling in simplified sync - #9412
Merged
Conversation
This was referenced Aug 6, 2026
Contributor
Author
This was referenced Aug 6, 2026
MiSikora
force-pushed
the
feature/mehow/simple-sync/ship-review-feedback
branch
from
August 6, 2026 12:02
80d07b8 to
d6b4f55
Compare
6 tasks
CDRussell
approved these changes
Aug 7, 2026
MiSikora
force-pushed
the
feature/mehow/simple-sync/ship-review-feedback
branch
from
August 7, 2026 08:24
d6b4f55 to
92ff1fa
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/pixels
branch
2 times, most recently
from
August 7, 2026 09:46
864d87d to
6533461
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/ship-review-feedback
branch
from
August 7, 2026 09:46
92ff1fa to
6996cb8
Compare
Contributor
Author
MiSikora
changed the base branch from
feature/mehow/simple-sync/pixels
to
graphite-base/9412
August 7, 2026 11:24
MiSikora
force-pushed
the
feature/mehow/simple-sync/ship-review-feedback
branch
from
August 7, 2026 11:25
6996cb8 to
4aaea52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1217224514372555?focus=true
Tech Design URL (if applicable): N/A
API Proposals URL(s) (if applicable): N/A
Description
Fixes edge-to-edge handling on the scrolling screens of the simplified Sync flow. These screens were reserving no space at the bottom under gesture navigation, so the last piece of content sat underneath the gesture pill instead of clearing it. The affected screens are the simplified Sync Settings screen, the QR code screen shown when syncing with another device, and the edit device screen. Each of these hosts its content in a scrolling container.
Steps to test this PR
Sync Settings screen
UI changes
Note
Low Risk
UI-only inset API swap on three Sync activities; no logic, networking, or data changes.
Overview
Fixes bottom edge-to-edge handling on three simplified Sync v2 screens that use a scroll view: Sync settings (
SyncActivity), display QR code (DisplayQrCodeActivity), and edit device (EditDeviceActivity).Each screen’s
configureEdgeToEdgeInsets()now callsapplyScrollableNavigationBarInsetsoncontentScrollViewinstead ofapplyNavigationBarInsets(..., drawBehindGestureNav = true). That matches the pattern used elsewhere for scrolling content so the list reserves bottom padding and the last row sits above the gesture navigation pill instead of underneath it.Reviewed by Cursor Bugbot for commit 4aaea52. Bugbot is set up for automated code reviews on this repo. Configure here.