Skip to content

Apply correct edge to edge handling in simplified sync - #9412

Merged
MiSikora merged 1 commit into
developfrom
feature/mehow/simple-sync/ship-review-feedback
Aug 7, 2026
Merged

Apply correct edge to edge handling in simplified sync#9412
MiSikora merged 1 commit into
developfrom
feature/mehow/simple-sync/ship-review-feedback

Conversation

@MiSikora

@MiSikora MiSikora commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1217224514372555?focus=true
Tech Design URL (if applicable): N/A
API Proposals URL(s) (if applicable): N/A

Description

Fixes edge-to-edge handling on the scrolling screens of the simplified Sync flow. These screens were reserving no space at the bottom under gesture navigation, so the last piece of content sat underneath the gesture pill instead of clearing it. The affected screens are the simplified Sync Settings screen, the QR code screen shown when syncing with another device, and the edit device screen. Each of these hosts its content in a scrolling container.

Steps to test this PR

Sync Settings screen

  • Open "Sync & Backup"
  • If content fits fully on the screen increase the font size or test with a smaller device.
  • Scroll to the bottom of the screen.
  • Verify the last item rests above the navigation bar and is not obscured by the gesture pill.

UI changes

Before After
Screenshot_20260806-090458 Screenshot_20260806-090405

Note

Low Risk
UI-only inset API swap on three Sync activities; no logic, networking, or data changes.

Overview
Fixes bottom edge-to-edge handling on three simplified Sync v2 screens that use a scroll view: Sync settings (SyncActivity), display QR code (DisplayQrCodeActivity), and edit device (EditDeviceActivity).

Each screen’s configureEdgeToEdgeInsets() now calls applyScrollableNavigationBarInsets on contentScrollView instead of applyNavigationBarInsets(..., drawBehindGestureNav = true). That matches the pattern used elsewhere for scrolling content so the list reserves bottom padding and the last row sits above the gesture navigation pill instead of underneath it.

Reviewed by Cursor Bugbot for commit 4aaea52. Bugbot is set up for automated code reviews on this repo. Configure here.

@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/ship-review-feedback branch from d6b4f55 to 92ff1fa Compare August 7, 2026 08:24
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/pixels branch 2 times, most recently from 864d87d to 6533461 Compare August 7, 2026 09:46
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/ship-review-feedback branch from 92ff1fa to 6996cb8 Compare August 7, 2026 09:46

MiSikora commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Aug 7, 11:24 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 7, 11:26 AM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 7, 11:38 AM UTC: @MiSikora merged this pull request with Graphite.

@MiSikora
MiSikora changed the base branch from feature/mehow/simple-sync/pixels to graphite-base/9412 August 7, 2026 11:24
@MiSikora
MiSikora changed the base branch from graphite-base/9412 to develop August 7, 2026 11:24
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/ship-review-feedback branch from 6996cb8 to 4aaea52 Compare August 7, 2026 11:25
@MiSikora
MiSikora merged commit 2cb2589 into develop Aug 7, 2026
18 checks passed
@MiSikora
MiSikora deleted the feature/mehow/simple-sync/ship-review-feedback branch August 7, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants