Make remove device dialog destructive - #9317
Merged
Merged
Conversation
Contributor
Author
16 tasks
This was referenced Jul 28, 2026
MiSikora
force-pushed
the
feature/msikora/simple-sync/race-conditions
branch
from
July 29, 2026 10:05
e325353 to
e6d6b41
Compare
MiSikora
force-pushed
the
feature/mehow/simple-sync/dialogs-style
branch
from
July 29, 2026 10:05
5c9dded to
13f7e6b
Compare
This was referenced Jul 29, 2026
CDRussell
approved these changes
Jul 30, 2026
Contributor
Author
MiSikora
changed the base branch from
feature/msikora/simple-sync/race-conditions
to
graphite-base/9317
July 30, 2026 10:42
MiSikora
force-pushed
the
feature/mehow/simple-sync/dialogs-style
branch
from
July 30, 2026 10:43
13f7e6b to
cb007f6
Compare
This was referenced Jul 31, 2026
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1215321458176118/task/1216916149729673?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1216103556496795/task/1216509582049467?focus=true
API Proposals URL(s) (if applicable): N/A
Description
Updates the button styles of the "Remove Device?" confirmation dialog on the Edit Device screen in the simplified sync flow, so the dialog signals that removing a device is a destructive action.
Steps to test this PR
Remove device dialog styling
UI changes
Note
Low Risk
UI-only dialog button styling with no changes to sync or device-removal logic.
Overview
The Remove Device confirmation in
EditDeviceActivity(sync v2) now passesDESTRUCTIVEto the primary Remove action andGHOST_ALTto Cancel, matching other destructive sync dialogs (e.g. delete account).Dialog text and behavior are unchanged; only button presentation is updated so removal reads as a destructive action.
Reviewed by Cursor Bugbot for commit cb007f6. Bugbot is set up for automated code reviews on this repo. Configure here.