Skip to content

Make remove device dialog destructive - #9317

Merged
MiSikora merged 1 commit into
developfrom
feature/mehow/simple-sync/dialogs-style
Jul 30, 2026
Merged

Make remove device dialog destructive#9317
MiSikora merged 1 commit into
developfrom
feature/mehow/simple-sync/dialogs-style

Conversation

@MiSikora

@MiSikora MiSikora commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1215321458176118/task/1216916149729673?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1216103556496795/task/1216509582049467?focus=true
API Proposals URL(s) (if applicable): N/A

Description

Updates the button styles of the "Remove Device?" confirmation dialog on the Edit Device screen in the simplified sync flow, so the dialog signals that removing a device is a destructive action.

Steps to test this PR

Remove device dialog styling

  • Sync with a second device using the legacy flow.
  • Open Sync Dev Settings.
  • Tap "Launch Sync Settings V2".
  • Tap the second device in the "Synced Devices" list.
  • Complete the device authentication prompt.
  • Tap "Remove Device".
  • Verify the dialog shows "Remove" as a red destructive button and "Cancel" as a neutral text button.

UI changes

Before After
before after

Note

Low Risk
UI-only dialog button styling with no changes to sync or device-removal logic.

Overview
The Remove Device confirmation in EditDeviceActivity (sync v2) now passes DESTRUCTIVE to the primary Remove action and GHOST_ALT to Cancel, matching other destructive sync dialogs (e.g. delete account).

Dialog text and behavior are unchanged; only button presentation is updated so removal reads as a destructive action.

Reviewed by Cursor Bugbot for commit cb007f6. Bugbot is set up for automated code reviews on this repo. Configure here.

MiSikora commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 30, 10:42 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 30, 10:44 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 30, 10:55 AM UTC: @MiSikora merged this pull request with Graphite.

@MiSikora
MiSikora changed the base branch from feature/msikora/simple-sync/race-conditions to graphite-base/9317 July 30, 2026 10:42
@MiSikora
MiSikora changed the base branch from graphite-base/9317 to develop July 30, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants