Skip to content

Add sync with another device UI - #9334

Merged
MiSikora merged 2 commits into
developfrom
feature/mehow/simple-sync/sync-another-device-ui
Aug 4, 2026
Merged

Add sync with another device UI#9334
MiSikora merged 2 commits into
developfrom
feature/mehow/simple-sync/sync-another-device-ui

Conversation

@MiSikora

@MiSikora MiSikora commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1216955031318054?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1216103556496795/task/1216509582049467?focus=true
API Proposals URL(s) (if applicable): N/A

Description

Adds the real UI for the connecting screen in the simplified Sync With Another Device flow. The screen opens after a valid sync code is recognized, either scanned on the "Scan QR" tab or pasted on the "Enter Code" tab. The screen shows a lock animation that plays once, a headline reading "Sync & Backup is end-to-end encrypted on all your devices.", and a "Connecting…" label with a spinner next to it. The actual connection logic is not part of this PR, so the screen stays in the connecting state.

Steps to test this PR

Sync in progress UI

  • Open Sync Dev Settings.
  • Tap "Launch Sync Settings V2".
  • Tap "Sync With Another Device".
  • Complete the device authentication prompt.
  • On the "Scan QR" tab, tap "I’m Ready to Scan".
  • Scan a sync QR code shown by another device.
  • Verify the connecting screen opens with a lock animation that plays once.
  • Verify the headline reads "Sync & Backup is end-to-end encrypted on all your devices.".
  • Verify a spinner is shown next to the "Connecting…" label below the headline.

UI changes

Screenshot_20260729-135819

Note

Low Risk
Presentation-only changes in sync v2 UI with no new networking, crypto, or state transitions; connection behavior is intentionally deferred.

Overview
Replaces the placeholder ExchangeSyncCodeActivity UI (magenta background and raw sync URL text) with the real connecting screen for the simplified Sync With Another Device flow.

The activity now uses activity_sync_v2_exchange_sync_code.xml: a one-shot Lottie lock animation, an E2E encryption headline, and a Connecting… line with a Material circular progress indicator on the label. Edge-to-edge for the Sync bucket is wired through EdgeToEdgeProvider / EdgeToEdgeHandler like other sync v2 screens.

New copy lives in donottranslate.xml (sync_another_device_v2_headline / sync_another_device_v2_body). No sync exchange or connection logic is added here—the screen stays in the connecting state after a valid code is scanned or pasted.

Reviewed by Cursor Bugbot for commit e4f7064. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 79a8317. Configure here.

@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from 9170a30 to faaaf23 Compare July 29, 2026 12:20
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/sync-another-device-ui branch from 79a8317 to f8df5b7 Compare July 29, 2026 12:20
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from faaaf23 to efdd0e2 Compare July 30, 2026 09:18
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/sync-another-device-ui branch from f8df5b7 to f9b44df Compare July 30, 2026 09:18
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from efdd0e2 to 93146eb Compare July 30, 2026 12:10
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/sync-another-device-ui branch 2 times, most recently from 29f8a19 to 844513c Compare July 30, 2026 12:14
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from 05629b6 to 9b554ef Compare July 30, 2026 12:59
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from 9b554ef to 41fbdeb Compare July 30, 2026 12:59
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/sync-another-device-ui branch from 844513c to e98dac4 Compare July 30, 2026 12:59
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from 41fbdeb to 9df052d Compare July 31, 2026 04:49
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/sync-another-device-ui branch from e98dac4 to eb576d3 Compare July 31, 2026 04:49
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from 9df052d to 08fc11a Compare August 3, 2026 12:44
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/sync-another-device-ui branch 2 times, most recently from 02fcf8f to 200e3c8 Compare August 3, 2026 13:13
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from 463e15b to b35588b Compare August 3, 2026 16:30
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/sync-another-device-ui branch 2 times, most recently from 600222b to 8825d77 Compare August 4, 2026 07:11
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/detect-scanned-code branch from b35588b to 5cccd63 Compare August 4, 2026 07:11

MiSikora commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Aug 4, 12:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 4, 12:43 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 4, 12:54 PM UTC: @MiSikora merged this pull request with Graphite.

@MiSikora
MiSikora changed the base branch from feature/mehow/simple-sync/detect-scanned-code to graphite-base/9334 August 4, 2026 12:41
@MiSikora
MiSikora changed the base branch from graphite-base/9334 to develop August 4, 2026 12:41
@MiSikora
MiSikora force-pushed the feature/mehow/simple-sync/sync-another-device-ui branch from 8825d77 to e4f7064 Compare August 4, 2026 12:42
@MiSikora
MiSikora merged commit a509801 into develop Aug 4, 2026
18 checks passed
@MiSikora
MiSikora deleted the feature/mehow/simple-sync/sync-another-device-ui branch August 4, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants