Repository navigation
Conversation
1 of 3 tasks
moetemp
force-pushed
the
moe/up/python-proto-modules
branch
from
October 27, 2026 18:35
fc0ccdc to
775b87d
Compare
This was referenced Oct 27, 2026
moetemp
force-pushed
the
moe/up/python-proto-modules
branch
2 times, most recently
from
October 28, 2026 16:37
fec09fb to
92cfcc2
Compare
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
1 of 3 tasks
moetemp
force-pushed
the
moe/up/oneof-record-case
branch
2 times, most recently
from
October 29, 2026 00:53
7d98eab to
a892bd7
Compare
moetemp
force-pushed
the
moe/up/python-proto-modules
branch
from
October 29, 2026 04:00
92cfcc2 to
81fd8c7
Compare
moetemp
force-pushed
the
moe/up/oneof-record-case
branch
from
October 29, 2026 06:28
a892bd7 to
5ae1c19
Compare
moetemp
force-pushed
the
moe/up/python-proto-modules
branch
from
October 29, 2026 06:28
81fd8c7 to
36a8328
Compare
moetemp
force-pushed
the
moe/up/oneof-record-case
branch
from
October 29, 2026 07:00
5ae1c19 to
2f6b64b
Compare
moetemp
force-pushed
the
moe/up/python-proto-modules
branch
from
October 29, 2026 07:00
36a8328 to
2f28526
Compare
moetemp
force-pushed
the
moe/up/oneof-record-case
branch
from
October 29, 2026 07:35
2f6b64b to
4391281
Compare
moetemp
force-pushed
the
moe/up/python-proto-modules
branch
from
October 29, 2026 07:35
2f28526 to
2497fc5
Compare
nexgen ships `proto/nexus/options.proto`, whose `nexus.python_module` file option names the Python module of a file's messages and enums. nexgen reads it from the raw descriptor bytes, since prost drops extension fields. The stream sample's protos set it, so Python imports them from the sample's streamprotos package, and basedpyright checks the stream service.
moetemp
force-pushed
the
moe/up/oneof-record-case
branch
from
October 29, 2026 09:29
4391281 to
3ff91ac
Compare
moetemp
force-pushed
the
moe/up/python-proto-modules
branch
from
October 29, 2026 09:29
2497fc5 to
52b7104
Compare
moetemp
marked this pull request as ready for review
October 29, 2026 09:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the
nexus.python_modulefile option, in a newproto/nexus/options.protothat the crate includes. A.protofile that sets it names the Python module of its messages and enums. A file that doesn't keeps the module that nexgen derives from its path.prost_types::FileOptionsdrops extension fields, so nexgen reads the option from the raw descriptor bytes.streams.bin, the Python and .NET bindings and the README's rebuild steps change with them.In the stream sample's Python output, the models import the Stream protos from
streamprotos.Why?
By default, Python imports a
temporal/...proto fromtemporalio, and the Stream protos oftemporalio/api#895aren't in a releasedtemporalio. The module depends on where the protos are installed, so the protos name it, not each WIT binding. sdk-python doesn't need the option, since it generates those protos intotemporalioitself.How did you test it?
Link to a test plan if any -
Backend unit tests cover the module choice and the read of the raw option, and a rejection fixture covers a bad module name.
test_stream_service.pyround-trips each read item kind through thestreamprotosclasses, and basedpyright checks the stream service.