Repository navigation
Conversation
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
2 times, most recently
from
October 28, 2026 16:37
be0ed9f to
d9ed245
Compare
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
moetemp
changed the base branch from
main
to
moe/up/resource-type-params-through-protos
October 28, 2026 22:57
1 of 3 tasks
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
from
October 29, 2026 04:00
d9ed245 to
8d7b2b8
Compare
moetemp
force-pushed
the
moe/up/resource-type-params-through-protos
branch
from
October 29, 2026 06:28
2acc4e9 to
fb0aedf
Compare
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
from
October 29, 2026 06:28
8d7b2b8 to
5c24067
Compare
moetemp
force-pushed
the
moe/up/resource-type-params-through-protos
branch
from
October 29, 2026 07:00
fb0aedf to
cc6f8ba
Compare
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
from
October 29, 2026 07:00
5c24067 to
33695de
Compare
The flag has the name of the user's own email, with another type. Today's output fills the flag with the user's email.
A resource method filled each request field from the resource field or param of the same name, whatever its type. So the user's own email went into the notify request's email flag. A source binds only when its type is the field's type, or the inner type of an optional field.
moetemp
force-pushed
the
moe/up/resource-type-params-through-protos
branch
from
October 29, 2026 07:35
cc6f8ba to
e7f9b2e
Compare
moetemp
force-pushed
the
moe/up/resource-binding-types
branch
from
October 29, 2026 07:35
33695de to
a27caee
Compare
Contributor
Author
|
Closing this. The Streams stack doesn't need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR makes a resource method fill a request field from a same-name resource field or parameter only when their types match. An optional field also takes a source of its inner type, but a required field doesn't take an optional source.
With no match, an optional field is unset or built from its own fields, as before. A required field leaves an implicit method unbound, and fails generation for a method with
@nexus.operation.The first commit adds an
emailflag to theuser-servicenotify request with today's output, and the second is the fix.It's based on #304.
Why?
Brook's Stream resource has a
statusof one enum, and its close request has astatusof another, soclosefilled the request with the Stream's own status. Brook's WIT hides the bug with astatusparameter onclose, souser-servicereproduces it.How did you test it?
Link to a test plan if any -
At the first commit, each language fills the
option<bool>flag with theemailstring. A unit test covers an implicit method, and a rejection fixture covers@nexus.operation.