Repository navigation
Conversation
This was referenced Oct 28, 2026
`@nexus.poll items=` makes the iterator yield the items of each page, and `resume=` names the helper that resumes after one item. The iterator's `next_request` lets a caller save its place.
moetemp
force-pushed
the
moe/up/varargs-unwrap-result-field
branch
from
October 29, 2026 04:00
bb29c8a to
56d99e2
Compare
moetemp
force-pushed
the
moe/up/poll-items
branch
from
October 29, 2026 04:00
d966e69 to
0ddb556
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR lets a Python poll iterator yield the items of each page, with a point to resume from.
items="<field>"names a list field of the response, and the iterator yields its items.python-resume=names an optional helper(page request, item) -> requestthat resumes after an item.PollIterator. Itsnext_requestresumes after the last item it yielded, and it'sNoneafter the last page.The stream sample's read yields each Record. The
poll-servicefeed yields itsexecutionsin Workflow code and in a client.It's based on #89, and it's on the fork for review before an upstream PR.
Why?
The proposal reads Records one by one, and a reader saves its place to resume after a restart. With the page iterator of temporalio#325, each caller looped over the Records and kept the offset itself.
How did you test it?
Link to a test plan if any -
The
poll-serviceWorkflow reads the feed's items through real Nexus endpoints.