Skip to content

[CI] Count a zombie as reaped in test_run_example_terminates_timeouts - #4547

Closed
huydhn wants to merge 1 commit into
mainfrom
osdc/fix-examples-zombie
Closed

huydhn wants to merge 1 commit into
mainfrom
osdc/fix-examples-zombie

Conversation

@huydhn

@huydhn huydhn commented Oct 9, 2026

Copy link
Copy Markdown
Contributor
  • Treat the killed child as gone once it is a zombie in test_run_example_terminates_timeouts.
  • On OSDC the job container's PID 1 is tail -f /dev/null, which never reaps orphans, so the child run_example kills stays a zombie and os.kill(pid, 0) still succeeds. Under linux_job_v2 PID 1 was the image's bash, which reaped it.

@pytorch-bot

pytorch-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4547

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit baeed8d with merge base 47bd395 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2026
@github-actions github-actions Bot added the CI Has to do with CI setup (e.g. wheels & builds, tests...) label Oct 9, 2026
@huydhn

huydhn commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #4544.

@huydhn huydhn closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant