Repository navigation
[CI] Fix the CI jobs that fail on the OSDC images - #4544
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4544
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 456836b with merge base 48a06fc ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
force-pushed
the
osdc/fix-libs-env
branch
from
October 9, 2026 18:30
e0e7d6f to
4284cfd
Compare
huydhn
added this pull request to stack #4546
October 9, 2026 18:30
huydhn
force-pushed
the
osdc/fix-libs-env
branch
2 times, most recently
from
October 9, 2026 18:37
bc5dba6 to
36bb11e
Compare
huydhn
force-pushed
the
osdc/fix-libs-env
branch
from
October 9, 2026 18:45
36bb11e to
1cabb80
Compare
huydhn
marked this pull request as ready for review
October 9, 2026 18:50
huydhn
force-pushed
the
osdc/fix-libs-env
branch
3 times, most recently
from
October 9, 2026 23:19
b82265c to
1bbc980
Compare
atalman
approved these changes
Oct 9, 2026
huydhn
force-pushed
the
osdc/fix-libs-env
branch
from
October 10, 2026 00:01
1bbc980 to
ef9572c
Compare
huydhn
force-pushed
the
osdc/fix-libs-env
branch
from
October 10, 2026 03:37
ef9572c to
f24617c
Compare
huydhn
force-pushed
the
osdc/fix-libs-env
branch
from
October 10, 2026 04:27
f24617c to
ad40ed5
Compare
huydhn
force-pushed
the
osdc/fix-libs-env
branch
from
October 10, 2026 07:01
ad40ed5 to
9d2e955
Compare
Contributor
Author
|
@pytorchbot drci |
huydhn
force-pushed
the
osdc/fix-libs-env
branch
from
October 10, 2026 08:22
9d2e955 to
456836b
Compare
Contributor
Author
|
@pytorchbot drci |
1 similar comment
Contributor
Author
|
@pytorchbot drci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install
python3-devin the procgen, safety-gymnasium, minari and sglang setups, because the OSDC image's Python has no headers and building torchrl fails onPython.h.Stop the habitat setup from putting
/usr/binfirst inPATHfor the rest of the script, because laterpip3calls then hit the system pip, which refuses to install on the Ubuntu 24.04 image. Also installlibglib2.0-0, which OpenCV needs and that image lacks.Install
cmakein the vllm and sglang setups, because the pinned tensordict builds a C++ extension and the OSDC image has no cmake. vllm takes it from apt, because pip builds tensordict in an isolated environment where thecmakewheel's launcher cannot import its own package.Move [Refactor] Bound GPU test parallelism and reap strays #4532's stray reaping into
helpers/reap_strays.shand run it on exit in the craftground and libero tests too, because their backgroundXvfbkeeps the job's output open and the job hangs until it times out.Treat the killed child as gone once it is a zombie in
test_run_example_terminates_timeouts(folded in from [CI] Count a zombie as reaped in test_run_example_terminates_timeouts #4547). On OSDC the job container's PID 1 istail -f /dev/null, which never reaps orphans, soos.kill(pid, 0)keeps succeeding on the zombie.Map the container's hostname to loopback in the olddeps tests, as
linux/scripts/run_all.shalready does, because the gloo and nccl transport tests inTestRayRBandtest_inference_server.pyfail withgaierrorresolving it.Install
python3-venvin the vllm, sglang, openx and minari setups, the jobs that download from the HF Hub, becauselinux_job_v3's HF cache sync falls back to installing the AWS CLI in a venv and the Ubuntu 24.04 image can't create one, soci-refresh-hf-cacheruns never upload the models they download.