Skip to content

[CI] Count a zombie as reaped in test_run_example_terminates_timeouts #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huydhn wants to merge 1 commit into from
Closed

[CI] Count a zombie as reaped in test_run_example_terminates_timeouts #4547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/unittest/examples/scripts/test_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,14 @@ def test_run_example_terminates_timeouts(tmp_path: Path) -> None:
os.kill(child_pid, 0)
except ProcessLookupError:
break
# A killed child re-parented to a PID 1 that never reaps orphans (OSDC's
# `tail -f /dev/null`) stays a zombie, which os.kill still reports.
try:
stat = Path(f"/proc/{child_pid}/stat").read_text()
if stat.rsplit(")", 1)[1].split()[0] == "Z":
break
except (FileNotFoundError, IndexError):
pass
time.sleep(0.01)
else:
pytest.fail(f"child process {child_pid} survived timeout cleanup")
Expand Down
Loading