Repository navigation
Scaffold the builder image without an add-on - #5
Merged
Merged
Conversation
Left in place it stays a packages/* workspace project, so a project built on the builder, which copies in its own add-on and pnpm-lock.yaml, fails the frozen-lockfile install with ERR_PNPM_OUTDATED_LOCKFILE. Drop the package, its root package.json dependency and its registry.config.ts entry, then refresh the lockfile.
This was referenced Oct 27, 2026
Generate the workspace with the new cookieplone-templates sub/aurora_project template, which has no add-on, instead of aurora_addon. The image no longer needs to remove the scaffolded plone-aurora add-on or unregister it. cookieplone 2.0.2 is needed for template names with a slash.
sneridagh
changed the title
sneridagh
added a commit
to plone/demo.plone.org
that referenced
this pull request
Oct 28, 2026
plone/aurora-builder 1.0.0-alpha.19 is re-released without the plone-aurora add-on (plone/container-aurora#5), so there is nothing to remove before the frozen-lockfile install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builder image used to scaffold a full
aurora_addoncalledplone-aurora, which stayed in/app/packages/plone-auroraas a workspace project. A project built on the builder copies in its own add-on and its ownpnpm-lock.yaml, which has no entry forplone-aurora. When its first install runs frozen (for example withCI=true, as demo.plone.org does), it fails:The builder now scaffolds with the new
sub/aurora_projecttemplate (plone/cookieplone-templates#490), the Aurora counterpart ofsub/frontend_project. It generates the workspace with nothing inpackages/, a rootpackage.jsonthat depends only on@plone/registryand@plone/aurora, and the stockregistry.config.ts. The image doesn't need any cleanup step.COOKIEPLONE_REPOSITORY_TAGis pinned to53f065a, themaincommit that merged Add the sub/aurora_project subtemplate cookieplone-templates#490.COOKIEPLONE_VERSIONmoves to 2.0.2. 2.0.0 exits with an error after generating a template whose name contains/(Handle template names with / in answers and replay files cookieplone#216).plone/auroraandplone/aurora-devnow run stock Aurora, with no extra add-on registered.Related: plone/cookieplone-templates#489 copies the add-on's own
package.jsonas-is in the Aurora add-on Dockerfile.Testing
Built locally with Aurora
1.0.0-alpha.19:packages/, and itsregistry.config.tsand rootpackage.jsonreference no add-on.plone/auroraandplone/aurora-devbuild, andplone/aurorastarts and serves on port 3000.export CI=trueso its firstpnpm installruns frozen, builds on the new builder and starts.