Repository navigation
Stop removing the scaffolded add-on in the Aurora image - #116
Merged
Merged
Conversation
plone/aurora-builder 1.0.0-alpha.19 is re-released without the plone-aurora add-on (plone/container-aurora#5), so there is nothing to remove before the frozen-lockfile install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plone/aurora-builder:1.0.0-alpha.19has been re-released (container-aurora tagv1.0.0-alpha.19.1) without the scaffoldedplone-auroraadd-on. The builder is now generated from the new cookieplonesub/aurora_projecttemplate, which has nothing inpackages/(plone/container-aurora#5, plone/cookieplone-templates#490).So
frontend-aurora/Dockerfileno longer needsrm -rf /app/packages/plone-aurorabefore its frozen-lockfile install. This PR removes it.Testing
packages/is empty, andregistry.config.tsregisters no add-on.pnpm installrunning frozen (CI=true), with 22 workspace projects instead of 23.corepack use pnpm@11.20.0step timed out fetching from the npm registry, as it did before this change. CI has been getting through that step.