Repository navigation
Copy the Aurora add-on package.json as-is in its Dockerfile - #489
Merged
Merged
Conversation
Merging its dependencies into the aurora-builder package.json kept the builder's own dependencies, so the result no longer matched the add-on's pnpm-lock.yaml and the frozen-lockfile install failed.
…le-package-json * origin/main: Include Nick's example add-on in the nick_backend workspace Read the Aurora image version from mrs.developer.json
Member
Author
|
@ericof Merging this one once is green, Aurora thinggies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, the Aurora add-on Dockerfile copied
package.jsontopackage.json.tempand merged itsdependenciesinto theplone/aurora-builderone. The merge kept the builder's own entries, so the result no longer matched the add-on'spnpm-lock.yaml, and the frozen-lockfile install failed withERR_PNPM_OUTDATED_LOCKFILE. The builder's"plone-aurora": "workspace:*"was one of those entries.The Dockerfile now copies the add-on's
package.jsonstraight to/app/package.json. There's no.tempcopy and no merge.This covers every Aurora template:
aurora_cmfplone,aurora_nickandaurora_nick_embeddedall get their frontend fromadd-ons/aurora_addon. The Voltosub/*_settingsDockerfiles build onplone/frontend-builderand are unchanged.Companion change: plone/container-aurora#5, which removes the scaffolded
plone-auroraadd-on from the builder image.Testing
aurora_addon,aurora_cmfplone,aurora_nickandaurora_nick_embeddedtemplate tests pass.make install, and built its Dockerfile on a builder with Scaffold the builder image without an add-on container-aurora#5 applied. The builder stage passes, includingpnpm installandCI=1 pnpm install --prod.Follow-up, not in this PR: the final stage's
corepack use pnpm@…runs a full uncachedpnpm installand times out after about 5 minutes. Switching it tocorepack installmakes that step take 6s.