Skip to content

Expose item on child collections - #126

Merged
wieslawsoltes merged 1 commit into
fix/html-content-interface-ownershipfrom
fix/child-collection-item
Sep 16, 2026
Merged

wieslawsoltes merged 1 commit into
fix/html-content-interface-ownershipfrom
fix/child-collection-item

Conversation

@wieslawsoltes

@wieslawsoltes wieslawsoltes commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem and change

Code OSS calls children.item(index) and childNodes.item(index), while WebScene returned arrays without the DOM collection method.

This change installs the existing bounded collection item callback and covers element filtering, node ordering, wrapper identity, and out-of-range null. It is one focused commit above #125.

Closes #80. The equivalent commit remains in draft consolidation PR #76.

Cumulative validation

  • Base layer b32eaf64; exact cumulative head 891e63bb
  • Pinned WebIDL generator consistency: 21 interfaces and 180 members; generated catalogs byte-identical
  • Release V8 native engine build
  • Cumulative dom-traversal-cloning-primitives contract: 10/10 local passes
  • Ownership/reflection performance gate: 500 cycles within 2 seconds
  • Warm cumulative focused runs: 58-61 ms locally
  • git diff --check
  • Remote validation runs only on this cumulative top to minimize CI and artifacts

Native GitHub stack #157

  1. Scope content properties to their HTML interfaces #125 — HTML interface ownership (Scope meta and template content properties to their HTML interfaces #79)
  2. Expose item on child collections #126 — current cumulative top — child collection item() (Expose item(index) on children and childNodes collections #80)

Merge both layers atomically through Stack #157 after the current-head related check passes.

@wieslawsoltes
wieslawsoltes force-pushed the fix/child-collection-item branch from 828b6e7 to 330fa19 Compare September 16, 2026 10:04
@wieslawsoltes
wieslawsoltes changed the base branch from review/code-oss-child-collections-base to fix/html-content-interface-ownership September 16, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose item(index) on children and childNodes collections

1 participant