Expose item on child collections

Author: wieslawsoltes

experiments/WebScene.NativeEngine.Probe/native/webscene_v8_runtime_dom_properties.inc

@@ -398,6 +398,10 @@
         for (uint32_t index = 0; index < children.size(); ++index) {
             result->Set(local_context, index, self->wrap_node(*children[index])).Check();
         }
+        result->Set(
+            local_context,
+            js_string(info.GetIsolate(), "item"),
+            v8::Function::New(local_context, collection_item).ToLocalChecked()).Check();
         info.GetReturnValue().Set(result);
     }
 

experiments/WebScene.NativeEngine.Probe/tests/native_v8_runtime_browser_dom_tests.inc

@@ -207,6 +207,37 @@ void test_specialized_content_properties(webscene_engine* engine)
         "specialized meta/template content properties diverged: " + result);
 }
 
+void test_child_collection_item(webscene_engine* engine)
+{
+    const auto result = evaluate(engine, R"JS(
+        (() => {
+          const host = document.createElement('div');
+          host.append('leading text');
+          const first = document.createElement('span');
+          const second = document.createElement('button');
+          host.append(first, second);
+          return {
+            children: [
+              typeof host.children.item,
+              host.children.item(0) === first,
+              host.children.item(1) === second,
+              host.children.item(2)
+            ],
+            childNodes: [
+              typeof host.childNodes.item,
+              host.childNodes.item(0).nodeType,
+              host.childNodes.item(1) === first,
+              host.childNodes.item(9)
+            ]
+          };
+        })()
+    )JS", "native-child-collection-item.js");
+    const auto expected = R"JSON({"children":["function",true,true,null],"childNodes":["function",3,true,null]})JSON";
+    require(
+        result == expected,
+        "child collection item lookup diverged: " + result);
+}
+
 void test_textarea_child_text_value_lifecycle(webscene_engine* engine)
 {
     const auto result = evaluate(engine, R"JS(

experiments/WebScene.NativeEngine.Probe/tests/native_v8_runtime_tests.cpp

@@ -515,6 +515,7 @@ int main()
             require(focused_engine != nullptr, "focused engine creation failed");
             test_dom_traversal_cloning_primitives(focused_engine);
             test_specialized_content_properties(focused_engine);
+            test_child_collection_item(focused_engine);
             webscene_engine_destroy(focused_engine);
             return 0;
         }
@@ -809,6 +810,7 @@ int main()
     test_dom_box_dimensions_primitives(engine);
     test_dom_traversal_cloning_primitives(engine);
     test_specialized_content_properties(engine);
+    test_child_collection_item(engine);
     test_fragment_replacement_and_inline_script_lifecycle(engine);
     test_textarea_child_text_value_lifecycle(engine);
     test_secondary_click(engine);