Skip to content

Restore Windows native package acceptance - #161

Merged
wieslawsoltes merged 1 commit into
fix/v8-clean-toolchain-environmentfrom
audit/windows-native-package-gate
Sep 16, 2026
Merged

wieslawsoltes merged 1 commit into
fix/v8-clean-toolchain-environmentfrom
audit/windows-native-package-gate

Conversation

@wieslawsoltes

@wieslawsoltes wieslawsoltes commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem and resulting behavior

The release package workflow retained its Windows build implementation but stopped scheduling win-x64. Green package runs therefore covered only macOS arm64 and Linux x64, which could not satisfy the cross-platform acceptance required by #79 and #80.

This change restores the existing Windows x64 native build and installed-package consumer, requires Windows in required/candidate evidence and release-package inventory, and adds a policy regression that keeps all three supported RIDs in every release gate.

Closes #160. Prerequisite for Stack #157 (#125 then #126). Related to #79, #80, and draft consolidation PR #76.

Native GitHub stack #170

  1. Isolate ANGLE from inherited Visual Studio state #166 — isolate ANGLE from inherited Visual Studio state.
  2. Isolate V8 from inherited Visual Studio state #169 — isolate V8/depot_tools from inherited Visual Studio state.
  3. Restore Windows native package acceptance #161 — current — restore Windows to the complete native package/evidence/consumer gate.

Stack #157 remains held until all prerequisite layers merge and its exact heads repeat the restored Windows gate.

Scope

  • Restore windows-2022 / win-x64 to the native package matrix.
  • Require win-x64 in cross-RID required and candidate evidence.
  • Require the Windows runtime package in release inventory verification.
  • Restore the Windows installed-package consumer.
  • Lock macOS arm64, Linux x64, and Windows x64 into those five gates with a policy unit test.

The existing PowerShell build remains the source of the Windows implementation. It builds the V8 runtime, runs the complete native CTest suite before packing, runs required Web Platform Test evidence against the packaged DLL, and produces the RID package.

Validation

  • python3 -m unittest scripts/tests/test_native_runtime_workflow_policy.py scripts/tests/test_verify_cross_rid_compatibility.py — 10 tests passed.
  • actionlint .github/workflows/native-runtime-packages.yml — passed.
  • git diff --check — passed.
  • Head 578c44b977a2f1c8a5d993277f02dfa3c2cb9c69: CI 35120274050 passed; package 35120274047 exposed the sequential Dawn→ANGLE environment failure tracked by Isolate ANGLE from inherited Visual Studio state #165.
  • Head 518eaeca142327c8c08b68e34e7007ae565b9758: CI 35123381487 passed; package 35123381474 proved Dawn→ANGLE succeeds, then exposed V8 inheriting the initialized Visual Studio environment. That boundary is tracked by Isolate V8 toolchain discovery from inherited Visual Studio state #168/Isolate V8 from inherited Visual Studio state #169.
  • Head 7ce801d97e08d8bf24c067e84b8cf7a0e18cc262: CI 35132417195 passed; package 35132417202 was canceled after review tightened partial-environment and cold-build acceptance in Isolate V8 from inherited Visual Studio state #169.
  • Head 585131f43f4c75f833b324821d6e96c22ae8ff1c: superseded CI 35136011140 and package 35136010867 were canceled when Windows cache acceptance was tightened to exact-key restore only.
  • Current Stack #170 head 24fdb3da1302364940444c331b6df9019585b6cb: exact CI 35136218314 and three-RID package 35136218434 are active.

The exact GitHub Windows build, package consumer, required/candidate evidence, and package-set results remain merge gates for this draft PR. After merge, Stack #157 must rebase and repeat the exact win-x64 package lane before either stacked PR merges.

@wieslawsoltes
wieslawsoltes force-pushed the audit/windows-native-package-gate branch from e9825ca to c0835db Compare September 16, 2026 15:29
@wieslawsoltes
wieslawsoltes changed the base branch from main to fix/windows-angle-sdk-selection September 16, 2026 15:30
Base automatically changed from fix/windows-angle-sdk-selection to main September 16, 2026 16:10
@wieslawsoltes
wieslawsoltes force-pushed the audit/windows-native-package-gate branch from c0835db to 578c44b Compare September 16, 2026 16:11
@wieslawsoltes
wieslawsoltes force-pushed the audit/windows-native-package-gate branch from 578c44b to 518eaec Compare September 16, 2026 16:40
@wieslawsoltes
wieslawsoltes removed this pull request from stack #164 September 16, 2026 16:40
@wieslawsoltes
wieslawsoltes changed the base branch from main to fix/angle-clean-toolchain-environment September 16, 2026 16:40
@wieslawsoltes
wieslawsoltes force-pushed the audit/windows-native-package-gate branch from 518eaec to 05d388d Compare September 16, 2026 18:05
@wieslawsoltes
wieslawsoltes removed this pull request from stack #167 September 16, 2026 18:05
@wieslawsoltes
wieslawsoltes changed the base branch from fix/angle-clean-toolchain-environment to fix/v8-clean-toolchain-environment September 16, 2026 18:05
@wieslawsoltes
wieslawsoltes force-pushed the audit/windows-native-package-gate branch from 05d388d to 7ce801d Compare September 16, 2026 18:07
@wieslawsoltes
wieslawsoltes force-pushed the audit/windows-native-package-gate branch from 7ce801d to 585131f Compare September 16, 2026 18:41
@wieslawsoltes
wieslawsoltes force-pushed the audit/windows-native-package-gate branch from 585131f to 24fdb3d Compare September 16, 2026 18:43
@wieslawsoltes
wieslawsoltes marked this pull request as ready for review September 16, 2026 20:01
@wieslawsoltes
wieslawsoltes merged commit 4909d46 into main Sep 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore Windows x64 native package acceptance to release gates

1 participant