Skip to content

fix(ui): YPE-3870 - drop font-mono from the version picker language count badge #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameronapak merged 2 commits into from
Aug 4, 2026
Merged

fix(ui): YPE-3870 - drop font-mono from the version picker language count badge #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bb7393
fix(ui): drop font-mono from the version picker language count badge
cameronapak Aug 4, 2026
e602dcf
test(ui): remove the version count badge class-name assertion
cameronapak Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/version-count-no-slashed-zero.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@youversion/platform-react-ui': patch
---

Fix the version count badge in the version picker's language trigger rendering with a monospace, slashed-zero font. The badge now inherits the picker's font and keeps `tabular-nums` for stable digit widths.
2 changes: 1 addition & 1 deletion packages/ui/src/components/bible-version-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ export function BibleVersionPickerLanguageTrigger({
</span>
<Badge
variant="secondary"
className="yv:h-5 yv:min-w-5 yv:rounded-full yv:px-1 yv:font-mono yv:tabular-nums"
className="yv:h-5 yv:min-w-5 yv:rounded-full yv:px-1 yv:tabular-nums"
>
{versionsLoading ? (
<LoaderIcon className="yv:size-3 yv:animate-spin" />
Expand Down
Loading