fix(ui): YPE-3870 - drop font-mono from the version picker language count badge - #316
Merged
Conversation
The version count badge in the version picker's language trigger used `yv:font-mono`, which rendered numerals in a monospace face with a slashed zero. That clashed with the rest of the picker UI on web and in the RN Expo SDK's WebView. Remove `yv:font-mono` so the badge inherits the picker's font, and keep `yv:tabular-nums` for stable digit widths. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e602dcf The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cameronapak
commented
Aug 4, 2026
The test asserted Tailwind class names rather than behavior, and jsdom does not compute fonts, so it could not verify the slashed zero it was meant to guard. The existing badge test already covers the count render. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
cameronapak
changed the title
bmanquen
approved these changes
Aug 4, 2026
cameronapak
deleted the
ype-3870-react-sdk-version-count-in-the-version-picker-language-list-renders-with-a-slashed-zero-font
branch
August 4, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YPE-3870 | Artifacts | Task
What problems was I solving
The version picker's language trigger shows a count badge, for example the number of Bible versions available in the selected language. That badge carried
yv:font-mono, so its digits rendered in the monospace stack instead of the picker's font. The monospace zero has a slash through it. Next to the language name in Inter, the badge looked like a different design.David flagged this in the RN Expo SDK launch review. It shows up on both surfaces: the Web SDK and the RN Expo SDK's WebView version picker sheet.
After this ships, the badge digits match the rest of the picker. Success is visual: zeros render without a slash, and the badge no longer reads as a separate font.
What user-facing changes did I ship
This is a two-file PR: one class removed, plus a changeset.
No API change. No prop change. Consumers get the fix on upgrade with no code edits.
Changeset
@youversion/platform-react-ui.Greptile Summary
The PR removes the monospace font utility from the Bible version picker’s language-count badge while retaining tabular numerals, and adds a patch changeset for the UI package.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
yv:font-monofrom the count badge so it inherits the picker’s sans-serif font while preservingyv:tabular-nums.Reviews (2): Last reviewed commit: "test(ui): remove the version count badge..." | Re-trigger Greptile
Context used: