Feature/backend reforge

.github/skills/wowsims-bulk-sim-handoff/SKILL.md

@@ -0,0 +1,84 @@
+---
+name: wowsims-bulk-sim-handoff
+description: 'Use when continuing, debugging, validating, or modifying WoWSims MoP Bulk Sim, local/server bulk sim, browser WASM concurrent bulk sim, BulkSimRequest/BulkSimResult protos, candidate generation, IndexedDB reforge caching, progress, abort behavior, or backend reforge integration for bulk candidates.'
+argument-hint: 'Describe the Bulk Sim bug, candidate flow, reforge/cache behavior, or validation task to continue.'
+---
+
+# WoWSims Bulk Sim Handoff
+
+## Scope
+- Bulk candidate generation and staged simulation flow.
+- Bulk reforge pre-pass integration and cache behavior.
+- Progress, abort semantics, and local vs WASM orchestration.
+
+## Architecture
+- Shared messages: proto/api.proto (BulkSimRequest, BulkSimResult, ReforgeOptimizeRequest).
+- Core staged runner: sim/core/bulk/bulk_sim.go.
+- Local/server reforge pre-pass wrapper: sim/web/bulk.go.
+- Web endpoint registration: sim/web/main.go (/bulkSimAsync uses sim/web.BulkSimAsync wrapper).
+- Frontend orchestration and cache partitioning: ui/core/sim.ts.
+- Bulk utilities and cache helpers: ui/core/components/individual_sim_ui/bulk/utils.ts.
+- Generic cache storage: ui/core/reforge_cache.ts.
+- Browser WASM Bulk Sim path: ui/core/wasm/bulk_sim.ts.
+
+## Core Invariants
+- Baseline gear source is base_request.raid.parties[0].players[0].equipment.
+- Candidate identity is stable via BulkGearCandidate.index.
+- With reforge_request enabled:
+  - Cache hits go to optimized_candidates.
+  - Work to optimize goes to candidates.
+- Before staged sim:
+  - Reforge pre-pass merges cache hits + newly optimized candidates.
+  - request.ReforgeRequest is cleared.
+- Dedup rules for sim input:
+  - Exclude baseline-equivalent gear.
+  - Exclude duplicate gear across optimized candidates.
+- For cache writes:
+  - Keep full optimized_candidates (including duplicates/baseline-equivalent results) so every input key can be written.
+
+## Local/Server Reforge Flow
+- Candidate generation runs unless request is fully cache-restored (candidates empty, optimized_candidates populated).
+- Reforge optimization emits BulkSimStageReforge progress before low/medium/high stages.
+- Reforge failures for an individual candidate fall back to original candidate gear instead of failing the entire request.
+- Abort returns partial optimized candidates that already completed.
+
+## Frontend/WASM Flow
+- WASM reforge path is frontend-orchestrated and uses per-gear optimizer calls.
+- IndexedDB cache values store optimized output gear, not just metadata.
+- Cache key is input-identity hash; output is restored from cache value.
+
+## Candidate Counting and Filtering
+- rawCombinations is the raw mixed-radix index space.
+- combinations is the filtered runnable count.
+- Required set-bonus matching scans raw index space, then filters.
+- Progress/reporting should reflect filtered candidate counts for user-visible totals.
+
+## Performance Guardrails
+- Avoid per-candidate allocations in hot loops.
+- Prefer preallocated imperative loops in candidate/cache helpers.
+- For backend reforge optimizer cache:
+  - Use read-friendly locking for hit-heavy paths.
+  - Reuse computed gear hash across includeGems fallback attempts.
+- Throttle progress emission frequency to avoid contention.
+
+## Logging Expectations
+- Candidate generation stage should log started and completed with duration.
+- Reforge stage should log a single started event (no duplicates) and completed summary.
+
+## Validation Commands
+```bash
+make proto
+npm run type-check
+go test -count=1 ./sim/core/bulk ./sim/web
+```
+
+For reforge-integration changes:
+```bash
+go test -count=1 ./sim/core/reforge_optimizer ./sim/web
+```
+
+## Fast Search Aids
+```bash
+rg -n "BulkSimReforge|reforge_request|optimized_candidates|BulkSimStageReforge" proto sim ui
+rg -n "bulkSimAsync|/bulkSimAsync" sim/web
+```

.github/skills/wowsims-reforge-optimizer-handoff/SKILL.md

@@ -0,0 +1,77 @@
+---
+name: wowsims-reforge-optimizer-handoff
+description: 'Use when continuing, debugging, validating, or modifying the WoWSims MoP reforge optimizer, /reforgeOptimizeAsync endpoint, HiGHS solver integration, gem/socket/cap logic, softcap breakpoints, or Rune of Re-Origination relative stat caps.'
+argument-hint: 'Describe the reforge optimizer bug, fixture, or behavior to continue.'
+---
+
+# WoWSims Reforge Optimizer Handoff
+
+## Scope
+- Core optimizer behavior in sim/core/reforge_optimizer.
+- Endpoint path /reforgeOptimizeAsync and worker integration.
+- HiGHS-backed MIP solving for reforge + gem + socket-bonus choices.
+- Relative stat cap logic (including Rune of Re-Origination behavior).
+
+## Architecture
+- Main flow: sim/core/reforge_optimizer/optimizer.go.
+- MIP model and constraints: sim/core/reforge_optimizer/solver.go.
+- Choice/cap/stat support: choices.go, caps.go, search.go, stats.go.
+- Gear apply/minimize regems: gear.go.
+- Gem/socket logic: gems.go.
+- Relative cap modeling: relative_stat_cap.go.
+- HiGHS bridge:
+  - Go non-browser: highswasm.go.
+  - Browser wasm: highs_js.go.
+- Frontend caller: ui/core/components/suggest_reforges_action.tsx.
+
+## Core Invariants
+- Final correctness is based on exact stats from core.ComputeStats, not only MIP deltas.
+- Optimizer must include reforge + gems + socket bonus decisions when enabled.
+- Socket bonus feasibility must be modeled with explicit link constraints.
+- On HiGHS failure, return error; do not silently downgrade to weaker fallback behavior.
+- Debug-heavy logs stay behind ReforgeOptimizeRequest.debug.
+
+## Cap and Breakpoint Rules
+- Validate and normalize cap settings before solve.
+- Enforce hard caps and breakpoint-derived rows directly in the MIP.
+- For exact-stat post-check failures, tighten relevant existing cap rows and re-solve.
+- Soft-cap scoring remains piecewise (pre-cap EP / post-cap EP).
+
+## Relative Stat Cap Rules
+- Use explicit linear constraints for forced-vs-constrained stat deltas.
+- Preserve raw Crit/Haste/Mastery deltas in choices for feasibility checks.
+- Validate relative-cap outcome with exact final stats and tighten rows if needed.
+- Windwalker forced-Mastery should constrain Mastery vs Crit and Mastery vs Haste; avoid adding unnecessary cross constraints unless fixture semantics require it.
+
+## Gem and Meta Rules
+- Meta gems are not normal swap targets.
+- Meta socket state must be preserved/restored during regem minimization.
+- Keep gem order stable in EquipmentSpec output.
+- Preserve class-specific stat dependency semantics used by scoring.
+
+## Bulk Sim Integration Contract
+- Bulk Sim uses ReforgeOptimizeRequest mode for bulk operations.
+- Bulk pre-pass may call optimizer twice per candidate when includeGems fallback is enabled.
+- Cache keys should represent input identity; cached values are optimized output gear.
+
+## Performance Guardrails
+- Keep solver model/build overhead low and allocation-aware.
+- Keep selected-choice validation and hot helpers allocation-light.
+- Avoid adding debug timers/alloc-heavy tracing outside debug mode.
+
+## Validation Commands
+```bash
+go test -count=1 ./sim/core/reforge_optimizer
+npm run type-check
+```
+
+For bulk integration changes:
+```bash
+go test -count=1 ./sim/core/reforge_optimizer ./sim/web
+```
+
+## Fast Search Aids
+```bash
+rg -n "ReforgeOptimizeRequest|relativeStatCap|softCap|breakpoint|HiGHS" proto sim ui
+rg -n "reforgeOptimizeAsync|ReforgeOptimize" sim ui
+```

.gitignore

@@ -2,6 +2,7 @@
 node_modules
 
 ui/core/index.ts
+ui/core/**/*_auto_gen.ts
 ui/*/*/index.html
 .dirstamp
 

assets/locales/en/translation.json

@@ -245,7 +245,7 @@
 		"description": "{{spec}} {{class}} simulations for World of Warcraft® Mists of Pandaria Classic.",
 		"basic_bis_disclaimer": "<p>Preset gear lists are intended as rough approximations of BIS, and will often not be the absolute highest-DPS setup for you. Your optimal gear setup will depend on many factors; that's why we have a sim!</p><p>Items may also be omitted from the presets if they are highly contested and clearly better utilized on other classes, to encourage equitable gearing for the raid as a whole.</p>",
 		"healing_sim_disclaimer": "*** WARNING - USE AT YOUR OWN RISK ***\n\nThe entire concept of a healing sim is EXPERIMENTAL. All results should be taken with an EXTREMELY large grain of salt.\n\nThis tool is currently more similar to a spreadsheet than a true sim. Options for specifying incoming damage profiles in order to have proper reactive rotations have not yet been added.",
-		"notice_local_download": {
+		"notice_native_download": {
 			"title": "Did you know?",
 			"message": "You can download our local sim to speed up your simulations significantly?",
 			"download_button": "Download"
@@ -776,7 +776,7 @@
 	"bulk_tab": {
 		"title": "Batch (<span class=\"text-success\">New</span>)",
 		"description": "<span className=\"bold\">Batch Simming</span> is a new feature akin to the <span className=\"bold\">Top Gear</span> sim on <a href=\"https://raidbots.com\" target=\"_blank\">Raidbots.com</a> that allows you to select multiple items and sim them find the best combinations.<br />This is an <span className=\"text-brand\">Alpha</span> feature, so if you have feedback or find a bug, please report it!",
-		"download_local": "Download the local sim for faster results.",
+		"download_native": "Download the local sim for faster results.",
 		"tabs": {
 			"setup": "Setup",
 			"results": "Results"
@@ -800,14 +800,24 @@
 			"item_unique": "{{itemName}} is unique and already added."
 		},
 		"settings": {
-			"combinations_count": "{{count}} Combinations",
+			"combinations_count": "{{amount}} Combinations",
 			"combination_singular": "1 Combination",
 			"iterations": "Iterations",
-			"fallback_gems": "Fallback Gems",
 			"inherit_upgrades": {
 				"label": "Inherit Upgrades",
 				"tooltip": "When enabled, items will inherit upgrades from the equipped item. Otherwise, items will be simmed without any upgrades."
 			},
+			"use_legacy_bulk_sim": {
+				"label": "Use legacy single-stage sim",
+				"tooltip": "By default, Bulk Sim runs large batches in multiple stages: a low-iteration pass to find likely contenders, a medium-iteration refinement pass, and a final high-iteration pass for the best remaining gear sets. Enable this only to force the legacy high-stage-only behavior."
+			},
+			"required_set_bonuses": {
+				"label": "Required Set Bonuses",
+				"none": "No requirement",
+				"require_2p": "Require 2P",
+				"require_4p": "Require 4P",
+				"available_pieces": "({{count}} available)"
+			},
 			"freeze_ring": {
 				"label": "Freeze ring slot",
 				"tooltip": "Freeze one equipped ring to reduce combination counts"
@@ -827,12 +837,17 @@
 			}
 		},
 		"progress": {
-			"total_combinations": "{{count}} total combinations.",
-			"reforging_rounds": "Running reforges",
+			"building_candidate_gear_sets": "Building candidate gear sets",
+			"restoring_reforges_from_cache": "Restoring reforges from cache",
+			"reforging_iteration_rounds": "Running reforges",
 			"baseline_round": "Running baseline round",
 			"refining_rounds": "Running refining rounds",
+			"low_iteration_rounds": "Running low iteration rounds",
+			"medium_iteration_rounds": "Running medium iteration rounds",
+			"high_iteration_rounds": "Running high iteration rounds",
 			"iterations_complete": "{{completed}} / {{total}}<br />iterations complete",
-			"seconds_remaining": "{{seconds}} seconds remaining"
+			"seconds_remaining": "{{seconds}} seconds remaining",
+			"time_remaining": "{{time}} remaining"
 		},
 		"notifications": {
 			"bulk_sim_cancelled": "Bulk sim cancelled.",
@@ -853,9 +868,6 @@
 			"gear_equipped": "Batch gear equipped!",
 			"current_gear": "Current Gear"
 		},
-		"gem_selector": {
-			"title": "Choose fallback Gem"
-		},
 		"import_modal": {
 			"title": "Bag Item Import",
 			"description_line1": "Import bag items from a JSON file, which can be created by the WowSimsExporter in-game AddOn.",
@@ -2383,13 +2395,11 @@
 				"enable_modification": "This will enable modification of the default EP weights and setting custom stat caps.",
 				"modify_in_editor": "Ep weights can be modified in the Stat Weights editor.",
 				"hard_cap_info": "If you want to hard cap a stat make sure to put the EP for that stat higher.",
-				"edit_weights": "Edit weights",
+				"edit_weights": "Change weights",
 				"include_gems": "Include gems",
 				"freeze_item_slots": "Freeze item slots",
 				"include_eotbp_socket": "Include EotBP Socket",
-				"include_eotbp_socket_tooltip": "Allows the optimiser to also include the \"Eye of the Black Prince\" socket in the optimization.",
-				"limit_execution_time": "Limit execution time",
-				"limit_execution_time_tooltip": "If checked, the solver will error out if the total computation time exceeds 30 seconds. If unchecked, then total computation time will be capped at 1 hour instead."
+				"include_eotbp_socket_tooltip": "Allows the optimiser to also include the \"Eye of the Black Prince\" socket in the optimization."
 			}
 		},
 		"header": {

assets/locales/fr/translation.json

@@ -245,7 +245,7 @@
         "description": "Simulations {{class}} {{spec}} pour World of Warcraft® Mists of Pandaria Classic.",
         "basic_bis_disclaimer": "<p>Les listes d'équipement prédéfinies fournie sont approximatives du meilleur équipement possible, et ne seront souvent pas la configuration optimale pour vous. Votre configuration d'équipement optimale dépendra de nombreux facteurs ; c'est pourquoi nous avons un simulateur !</p><p>Les objets peuvent également être omis des préréglages s'ils sont très contestés et clairement mieux utilisés sur d'autres classes, pour encourager un équipement équitable pour le raid dans son ensemble.</p>",
         "healing_sim_disclaimer": "*** AVERTISSEMENT - UTILISEZ À VOS PROPRES RISQUES ***\n\nLe concept entier d'un simulateur de soins est EXPÉRIMENTAL. Tous les résultats doivent être pris avec un grain de sel EXTREMEMENT important.\n\nCet outil est actuellement plus similaire à une feuille de calcul qu'à un véritable simulateur. Les options pour spécifier les profils de dégâts entrants afin d'avoir des rotations réactives appropriées n'ont pas encore été ajoutées.",
-        "notice_local_download": {
+        "notice_native_download": {
             "title": "Le saviez-vous ?",
             "message": "Vous pouvez télécharger notre simulateur en local pour accélérer considérablement vos simulations ?",
             "download_button": "Télécharger"
@@ -776,7 +776,7 @@
     "bulk_tab": {
         "title": "Lot (<span class=\"text-success\">Nouveau</span>)",
         "description": "<span className=\"bold\">Simulation par lot</span> est une nouvelle fonctionnalité similaire à la simulation <span className=\"bold\">Top Gear</span> sur <a href=\"https://raidbots.com\" target=\"_blank\">Raidbots.com</a> qui vous permet de sélectionner plusieurs objets et de les simuler pour trouver les meilleures combinaisons.<br />C'est une fonctionnalité <span className=\"text-brand\">Alpha</span>, donc si vous avez des commentaires ou trouvez un bug, veuillez le signaler !",
-        "download_local": "Téléchargez le simulateur en local pour des résultats plus rapides.",
+        "download_native": "Téléchargez le simulateur en local pour des résultats plus rapides.",
         "tabs": {
             "setup": "Configuration",
             "results": "Résultats"
@@ -800,14 +800,24 @@
             "item_unique": "{{itemName}} est unique et a déjà été ajouté."
         },
         "settings": {
-            "combinations_count": "{{count}} Combinaisons",
+            "combinations_count": "{{amount}} Combinaisons",
             "combination_singular": "1 Combinaison",
             "iterations": "Itérations",
-            "fallback_gems": "Gemmes de secours",
             "inherit_upgrades": {
                 "label": "Hériter des améliorations",
                 "tooltip": "Lorsque cette option est activée, les objets hériteront des améliorations de l'objet équipé. Sinon, les objets seront simulés sans aucune amélioration."
-            },
+			},
+			"use_legacy_bulk_sim": {
+				"label": "Utiliser la simulation mono-étape héritée",
+				"tooltip": "Par défaut, Bulk Sim exécute les lots volumineux en plusieurs étapes : une passe à faible nombre d'itérations pour trouver les candidats prometteurs, une passe de raffinement à nombre moyen d'itérations, puis une passe finale à nombre élevé d'itérations pour les meilleurs ensembles restants. Activez cette option uniquement pour forcer l'ancien comportement avec une seule passe finale."
+            },
+			"required_set_bonuses": {
+				"label": "Bonus d'ensemble requis",
+				"none": "Aucune exigence",
+				"require_2p": "Exiger 2P",
+				"require_4p": "Exiger 4P",
+				"available_pieces": "({{count}} disponibles)"
+			},
             "freeze_ring": {
                 "label": "Geler un emplacement d'anneau",
                 "tooltip": "Geler un anneau équipé pour réduire le nombre de combinaisons"
@@ -827,12 +837,17 @@
             }
         },
         "progress": {
-            "total_combinations": "{{count}} combinaisons totales.",
-			"reforging_rounds": "Exécution des reforges",
+			"building_candidate_gear_sets": "Création des ensembles d'équipement candidats",
+			"restoring_reforges_from_cache": "Restauration des reforges depuis le cache",
+			"reforging_iteration_rounds": "Exécution des reforges",
 			"baseline_round": "Exécution du tour de référence",
             "refining_rounds": "Exécution des tours d'affinage",
+			"low_iteration_rounds": "Exécution des tours à faible itération",
+			"medium_iteration_rounds": "Exécution des tours à itération moyenne",
+			"high_iteration_rounds": "Exécution des tours à forte itération",
             "iterations_complete": "{{completed}} / {{total}}<br />itérations terminées",
-            "seconds_remaining": "{{seconds}} secondes restantes"
+			"seconds_remaining": "{{seconds}} secondes restantes",
+			"time_remaining": "Il reste {{time}}"
         },
         "notifications": {
             "bulk_sim_cancelled": "Simulation par lot annulée.",
@@ -853,9 +868,6 @@
             "gear_equipped": "Équipement du lot équipé !",
             "current_gear": "Équipement actuel"
         },
-        "gem_selector": {
-            "title": "Choisir la gemme par défaut"
-        },
         "import_modal": {
             "title": "Importation d'objets de sac",
             "description_line1": "Importez des objets de sac à partir d'un fichier JSON, qui peut être créé par l'AddOn en jeu WowSimsExporter.",
@@ -2388,9 +2400,7 @@
 				"include_gems": "Inclure les gemmes",
 				"freeze_item_slots": "Verrouiller certains emplacements",
 				"include_eotbp_socket": "Inclure le socket EotBP",
-				"include_eotbp_socket_tooltip": "Permet à l'optimiseur d'inclure également le socket \"Œil du Prince Noir\" dans l'optimisation.",
-				"limit_execution_time": "Limiter le temps d'exécution",
-				"limit_execution_time_tooltip": "Si coché, le solveur se terminera en erreur si le temps de calcul total dépasse 30 secondes. Si décoché, le temps de calcul total sera plafonné à 1 heure."
+				"include_eotbp_socket_tooltip": "Permet à l'optimiseur d'inclure également le socket \"Œil du Prince Noir\" dans l'optimisation."
 			}
 		},
 		"header": {

go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8
 	github.com/spf13/cobra v1.7.0
 	github.com/tailscale/hujson v0.0.0-20221223112325-20486734a56a
+	github.com/tetratelabs/wazero v1.11.0
 	golang.org/x/exp v0.0.0-20250305212735-054e65f0b394
 	golang.org/x/text v0.24.0
 	google.golang.org/protobuf v1.36.10
@@ -24,7 +25,7 @@ require (
 	github.com/ncruces/go-strftime v0.1.9 // indirect
 	github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
-	golang.org/x/sys v0.31.0 // indirect
+	golang.org/x/sys v0.38.0 // indirect
 	modernc.org/libc v1.62.1 // indirect
 	modernc.org/mathutil v1.7.1 // indirect
 	modernc.org/memory v1.9.1 // indirect