Feature/backend reforge#1428
Open
1337LutZ wants to merge 171 commits into
Open
Conversation
…orge # Conflicts: # assets/database/db.bin # sim/death_knight/blood/TestBlood.results # sim/death_knight/frost/TestFrostMasterfrost.results # sim/death_knight/frost/TestFrostTwoHand.results # sim/death_knight/unholy/TestUnholy.results # sim/druid/balance/TestBalance.results # sim/druid/feral/TestFeral.results # sim/druid/guardian/TestGuardian.results # sim/hunter/beast_mastery/TestBeastMastery.results # sim/hunter/marksmanship/TestMarksmanship.results # sim/hunter/survival/TestSurvival.results # sim/mage/arcane/TestArcane.results # sim/mage/fire/TestFire.results # sim/mage/frost/TestFrost.results # sim/monk/brewmaster/TestBrewmaster.results # sim/monk/windwalker/TestWindwalker.results # sim/paladin/protection/TestProtection.results # sim/paladin/retribution/TestRetribution.results # sim/priest/shadow/TestShadow.results # sim/shaman/elemental/TestElemental.results # sim/shaman/enhancement/TestEnhancement.results # sim/warlock/affliction/TestAffliction.results # sim/warlock/demonology/TestDemonology.results # sim/warlock/destruction/TestDestruction.results # sim/warrior/arms/TestArms.results # sim/warrior/fury/TestFury.results # sim/warrior/protection/TestProtectionWarrior.results
…sults The reforge optimizer re-implemented random-suffix scaling with the divide-before-multiply order that master fixed in #1504; use the shared Item.ScaledRandomSuffixStats helper instead. Regenerate expected test results after the master merge (arbitrary conflict resolution during the merge left them stale) and update the multi-softcap and expertise optimizer fixtures: with the stat-rounding changes the solver now lands hit exactly on the 7.50% cap (2550) instead of one point over, and picks a slightly different haste/mastery split around the softcap. Fixtures edited by hand to preserve formatting; UPDATE_FIXTURES=1 reformats all fixture files.
…orge # Conflicts: # sim/druid/guardian/TestGuardian.results # sim/mage/frost/TestFrost.results # ui/core/components/suggest_reforges_action.tsx # ui/druid/guardian/builds/ij_default.build.json # ui/druid/guardian/gear_sets/p5.gear.json # ui/druid/guardian/gear_sets/p5_offensive.gear.json # ui/druid/guardian/sim.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sim_concurrentin awasmsubfolder and split all the WASM concurrency sims