Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
There was a problem hiding this comment.
Pull request overview
This PR updates neighsyncd to honor IPv6 link-local-only mode for VLAN subinterfaces by reusing the shared subinterface name parser, ensuring consistent behavior across canonical (e.g., Ethernet0.10) and short (e.g., Eth0.10) subinterface names. It also introduces mock unit tests to validate the updated lookup logic against CONFIG_DB’s VLAN_SUB_INTERFACE table.
Changes:
- Extend
NeighSync::isLinkLocalEnabled()to treat valid subinterface names asVLAN_SUB_INTERFACEentries (viaswss::subIntf). - Build/link
subintfsupport intoneighsyncd. - Add and register new mock unit tests covering VLAN subinterface link-local-only enable/disable behavior.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/mock_tests/neighsyncd/neighsync_ut.cpp | Adds new mock unit tests for link-local-only behavior on VLAN subinterfaces (long and short names). |
| tests/mock_tests/Makefile.am | Registers tests_neighsyncd and defines its build sources/linking. |
| neighsyncd/neighsync.h | Adds CONFIG_DB table handle for VLAN_SUB_INTERFACE. |
| neighsyncd/neighsync.cpp | Uses swss::subIntf parsing to route subinterface link-local-only lookups to VLAN_SUB_INTERFACE. |
| neighsyncd/Makefile.am | Adds lib include path and links subintf.cpp into the daemon build. |
| .gitignore | Ignores the new tests_neighsyncd test binary output. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
@sudharr86 , please fix conflicts |
60d2fd4 to
7cf08d4
Compare
|
/azp run |
|
@prsunny Rebased the branch onto current |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
7cf08d4 to
7caf160
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@sudharr86 @prsunny are you still looking at this PR? |
Yes I am still on this. Resolved the conflicts last week. |
Look up dotted Ethernet and PortChannel subinterfaces in VLAN_SUB_INTERFACE when deciding whether to accept IPv6 link-local neighbors. This prevents neighsyncd from dropping link-local neighbors learned on VLAN subinterfaces when ipv6_use_link_local_only is enabled. Signed-off-by: sudharr86 <203154411+sudharr86@users.noreply.github.com>
Use the shared swss::subIntf parser when classifying VLAN subinterfaces for IPv6 link-local neighbor processing. This accepts both long names such as Ethernet0.10 and short names such as Eth0.10 while rejecting non-SONiC dotted interface names. Add mock tests for the supported and rejected cases. Signed-off-by: sudharr86 <203154411+sudharr86@users.noreply.github.com>
7caf160 to
8eff2cd
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@croos12 @prsunny Rebased again onto current |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4708 in repo sonic-net/sonic-swss |
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
11 similar comments
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
Summary
Update
neighsyncdso IPv6 link-local-only mode is honored for VLAN subinterfaces. The change also uses the common subinterface parser so canonical and short subinterface names are handled consistently.Why
Neighbor sync already checks link-local-only mode for routed interfaces. VLAN subinterfaces need the same lookup path so their IPv6 link-local behavior is reflected correctly.
Changes
Related
Validation
git diff --check upstream/master..HEAD