[agent][cfggen] Fix len() called with no arguments in PortChannel Fallback parsing - #26404
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ba940cd to
94303b4
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…lback parsing minigraph.py:969 calls len() with no arguments, causing TypeError when parsing a PortChannel with a Fallback element. The correct argument is pcmbr_list, matching the non-Fallback branch on line 971. Fixes: sonic-net#26399 Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com>
94303b4 to
55fa8e9
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The T1-LAG failure is a legit failure but not related to this change. Retrying |
…lback parsing (sonic-net#26404) minigraph.py:969 calls len() with no arguments, causing TypeError when parsing a PortChannel with a Fallback element. The correct argument is pcmbr_list, matching the non-Fallback branch on line 971. Fixes: sonic-net#26399 Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Co-authored-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: mhchann <mhchann082@gmail.com>
…lback parsing (sonic-net#26404) minigraph.py:969 calls len() with no arguments, causing TypeError when parsing a PortChannel with a Fallback element. The correct argument is pcmbr_list, matching the non-Fallback branch on line 971. Fixes: sonic-net#26399 Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Co-authored-by: Rustiqly <rustiqly@users.noreply.github.com>
…lback parsing (sonic-net#26404) minigraph.py:969 calls len() with no arguments, causing TypeError when parsing a PortChannel with a Fallback element. The correct argument is pcmbr_list, matching the non-Fallback branch on line 971. Fixes: sonic-net#26399 Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Co-authored-by: Rustiqly <rustiqly@users.noreply.github.com>
|
This PR has backport request label(s) for branch(es): msft-202503,202505,202511,202605, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202503: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
|
Hi — this PR is flagged for cherry-pick to the 202605 branch (
This helps us track readiness and ensures we don't cherry-pick untested changes. Thanks! Comment by @vaibhavhd via automated tooling |
|
Cherry-pick PR to msft-202503: Azure/sonic-buildimage-msft#2810 |
|
@rustiqly cherry pick PR didn't pass PR checker after retry. Please help check! Thanks. ---Powered by SONiC BuildBot
|
|
Cherry-pick PR to msft-202512: Azure/sonic-buildimage-msft#3004 |
|
This PR has backport request label(s) for branch(es): msft-202512, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202512: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
6 participants
What I did
Fix
len()called with no arguments inminigraph.py:969, which crashes PortChannel Fallback parsing withTypeError.How I did it
Changed
len()tolen(pcmbr_list), matching the non-Fallback branch on line 971.How to verify it
Parse a minigraph XML containing a PortChannel with a
<Fallback>element — it should no longer crash.Which release branch to backport
master
Description for the changelog
Fix TypeError crash in minigraph PortChannel Fallback parsing due to len() called with no arguments.
Fixes: #26399