[action] [PR:26404] [agent][cfggen] Fix len() called with no arguments in PortChannel Fallback parsing - #2810
Open
mssonicbld wants to merge 1 commit into
Open
mssonicbld wants to merge 1 commit into
mssonicbld wants to merge 1 commit into
Conversation
…lback parsing #### What I did Fix `len()` called with no arguments in `minigraph.py:969`, which crashes PortChannel Fallback parsing with `TypeError`. #### How I did it Changed `len()` to `len(pcmbr_list)`, matching the non-Fallback branch on line 971. #### How to verify it Parse a minigraph XML containing a PortChannel with a `<Fallback>` element — it should no longer crash. #### Which release branch to backport master #### Description for the changelog Fix TypeError crash in minigraph PortChannel Fallback parsing due to len() called with no arguments. Fixes: #26399 Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-buildimage#26404 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
Author
|
This cherry pick PR has been opened for more than 3 days. The mssonicbld will attempt to retry. ---Powered by SONiC BuildBot
|
Collaborator
Author
|
/azpw retry |
Collaborator
Author
|
Arvindsrinivasan Lakshmi Narasimhan (@arlakshm) The cherry pick PR didn't pass PR checker after retry. Left a comment in original PR sonic-net/sonic-buildimage#26404 to notify author. ---Powered by SONiC BuildBot
|
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix
len()called with no arguments inminigraph.py:969, which crashes PortChannel Fallback parsing withTypeError.How I did it
Changed
len()tolen(pcmbr_list), matching the non-Fallback branch on line 971.How to verify it
Parse a minigraph XML containing a PortChannel with a
<Fallback>element — it should no longer crash.Which release branch to backport
master
Description for the changelog
Fix TypeError crash in minigraph PortChannel Fallback parsing due to len() called with no arguments.
Fixes: #26399
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com