Skip to content

Fix IP listening in tests and enhance DOM bundle assertions #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M-arcus wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −2
Open

Fix IP listening in tests and enhance DOM bundle assertions #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2093a5
Fix listen Ip in test
M-arcus Sep 8, 2026
dfcd783
Fix DOM bundle test asserting a non-AMP fixture is AMP
M-arcus Sep 8, 2026
70def5f
Add severity to the expected DOM advice keys
M-arcus Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/api/domTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ for (const browser of BROWSERS) {
30_000
);
const result = await driver.executeScript('return ' + bundle);
t.truthy(result?.advice?.info?.amp);
// Ordinary page, so info.amp is legitimately false — assert the
// bundle produced the info block, not that the page is AMP.
t.is(result.advice.info.amp, false);
t.truthy(result.advice.performance.adviceList);
t.is(result.url, url);
}
);
}
1 change: 1 addition & 0 deletions test/dom/adviceTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const KEYS = [
'advice',
'score',
'weight',
'severity',
'offending',
'tags'
];
Expand Down
4 changes: 3 additions & 1 deletion test/help/webserver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ export async function startServer(useHttp2) {
if (!isListening) {
await new Promise((resolveCb, rejectCb) => {
server
.listen(0, '0.0.0.0')
// Loopback, not 0.0.0.0: the browsers run on this machine, and
// Firefox refuses http://0.0.0.0:port where Chrome tolerates it.
.listen(0, '127.0.0.1')
.on('error', rejectCb)
.on('listening', () => {
isListening = true;
Expand Down