Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the test suite and test infrastructure, focusing on more accurate assertions in DOM tests and better compatibility for the local web server. The main changes are grouped below:
Test assertion improvements:
test/api/domTest.js, updated assertions to explicitly check thatinfo.ampisfalsefor ordinary pages, verify that theadvice.performance.adviceListexists, and confirm the returned URL matches the expected value. This makes the test expectations clearer and more robust.test/dom/adviceTest.js, added'severity'to the list of expected keys, ensuring that tests now check for the presence of this property in advice objects.Test infrastructure fix:
test/help/webserver.js, changed the server binding from'0.0.0.0'to'127.0.0.1'to improve browser compatibility, as Firefox does not accepthttp://0.0.0.0:portURLs while Chrome does. This ensures tests run reliably across browsers.