Repository navigation
[MoE] Remove the unused sycl::queue in moe_align_block_size - #590
Merged
Merged
Conversation
The queue was never used, the kernels go to the current XPU stream, and creating it cost 1-2 ms of host time per call. Signed-off-by: Witold Dziurdz <witold.dziurdz@intel.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the removal of unused per-call SYCL queue construction.
No open issues 🎉
What changed in this PR
Removes unused per-call SYCL queue construction from moe_align_block_size to reduce host overhead in MoE inference. Kernel submissions remain on the current XPU stream.
Changes:
- Deletes the unused
sycl::queuevariable without changing kernel logic. - Reports improved DeepSeek decode latency and 5,168 passing MoE alignment tests.
| File | Description |
|---|---|
src/sycl/MoEAlign.cpp |
Removes unused queue construction from moe_align_block_size. |
Review effort: Balanced
rahulvijayaraghavan
approved these changes
Oct 29, 2026
Contributor
Author
|
cc @airMeng @sunjiweiswift could you take a look? |
airMeng
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moe_align_block_sizecreates asycl::queueon every call that is never used; the kernels are submitted to the current XPU stream. Creating it costs 1-2 ms of host time per call, and SGLang's Triton MoE runner calls this op once per MoE layer per forward, so eager decode becomes host bound.DeepSeek on Arc Pro B60, SGLang with
--attention-backend triton --moe-runner-backend triton,sglang.benchmark.one_batch1024 in / 32 out:Test
5168 passed.