[ESSREDUCE] Move esspolarization to essreduce#434
Conversation
| @@ -0,0 +1,90 @@ | |||
| # SPDX-License-Identifier: BSD-3-Clause | |||
| # Copyright (c) 2025 Scipp contributors (https://github.com/scipp) | |||
| # ruff: noqa: E402, F401, I | |||
There was a problem hiding this comment.
| # ruff: noqa: E402, F401, I |
Not sure this is needed?
| import importlib.metadata | ||
|
|
||
| try: | ||
| __version__ = importlib.metadata.version("esspolarization") | ||
| except importlib.metadata.PackageNotFoundError: | ||
| __version__ = "0.0.0" | ||
|
|
||
| del importlib |
There was a problem hiding this comment.
I guess this should go away? It should just use the version of essreduce.
|
|
||
| del importlib | ||
|
|
||
|
|
There was a problem hiding this comment.
Maybe we can add a docstring here for the polarization submodule that describes a little the contents?
| @@ -31,6 +31,7 @@ | |||
| logging | |||
There was a problem hiding this comment.
I think you are missing the docs contents of esspolarization? e.g. https://scipp.github.io/esspolarization/user-guide/sans-polarization-analysis-methodology.html
That said, I don't know how much of it we want to keep, but I would say at least to start we would want to keep all of it?
There was a problem hiding this comment.
Yes that's true, I forgot to move that 👍
| "TotalPolarizationCorrectedData", | ||
| "TransmissionFunction", | ||
| "Up", | ||
| ] |
There was a problem hiding this comment.
I think you should also add polarization in the top level init ?
|
Although... Doing it this way we loose the history of the |
You mean the history of the esspolarization? In that case, in #276, we don't need to update pixi.toml or readme since we know that it'll be merged into essreduce. |
Yes! do that 🙂 |
As suggested in #276