Open
Conversation
jokasimr
force-pushed
the
move-polarization2
branch
from
df8ad83 to
f121924
Compare
nvaytet
reviewed
Apr 17, 2026
| @@ -1,16 +1,5 @@ | |||
| # SPDX-License-Identifier: BSD-3-Clause | |||
| # Copyright (c) 2025 Scipp contributors (https://github.com/scipp) | |||
| # ruff: noqa: E402, F401, I | |||
| "Polarized", | ||
| "Polarizer", | ||
| "PolarizingElement", | ||
| "ReducedSampleDataBySpinChannel", |
Member
There was a problem hiding this comment.
Still missing the addition of polarization to the essreduce/__init__.py?
cf #434 (comment)
nvaytet
reviewed
Apr 17, 2026
Co-authored-by: Neil Vaytet <[email protected]>
nvaytet
reviewed
Apr 17, 2026
Member
There was a problem hiding this comment.
This index shows up as User Guide > User Guide.
We need to change the title to Polarization in the polarization/index.md.
Also, the Overview mermaid graph from the old docs does not show up in the new docs.
(and sorry I keep finding new stuff, instead of giving you everything in one go...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #276