Skip to content

fix(check-workflows): mock action-artifacts capability probe endpoints #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matthiasL-scality wants to merge 2 commits into
base: development/2.15
Choose a base branch
from
Draft

fix(check-workflows): mock action-artifacts capability probe endpoints #2450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f01dc
fix(check-workflows): mock action-artifacts capability probe endpoints
matthiasL-scality Jun 26, 2026
10196d4
test(check-workflows): pin archive-artifacts action to action-artifac…
matthiasL-scality Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/archive-artifacts/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ runs:
steps:
- name: Setup artifacts link
id: setup-artifacts
uses: scality/action-artifacts@v4
uses: scality/action-artifacts@4.3.0
with:
method: setup
url: https://artifacts.scality.net
Expand Down Expand Up @@ -255,7 +255,7 @@ runs:
continue-on-error: true

- name: Upload artifacts
uses: scality/action-artifacts@v4
uses: scality/action-artifacts@4.3.0
with:
method: upload
url: https://artifacts.scality.net
Expand Down
23 changes: 23 additions & 0 deletions tests/workflows/archive-artifacts.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,27 @@ beforeEach(async () => {
body: [],
},
},
// action-artifacts@v4.5+ probes these endpoints before each upload to detect

@claude claude Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment says @v4.5+ but the PR description says @4.3.0 introduced the probe (and the action is pinned to 4.3.0). Update the version reference to match.

Suggested change
// action-artifacts@v4.5+ probes these endpoints before each upload to detect
// action-artifacts@4.3.0+ probes these endpoints before each upload to detect

// presigned/multipart upload capability. Reply 404 = capability unavailable,
// which makes the action fall back to the basic upload path.
presignUpload: {
path: "/presign-upload/{name}/{file}",
method: "get",
parameters: {
query: [],
path: ["name", "file"],
body: [],
},
},
presignUploadPart: {
path: "/presign-upload-part/{name}/{file}",
method: "get",
parameters: {
query: ["partNumber", "uploadId"],
path: ["name", "file"],
body: [],
},
},
},
},
},
Expand Down Expand Up @@ -173,6 +194,8 @@ function commonMockApi(...extraMocks: any[]) {
mockapi.mock.artifacts.root.uploadKindLogs().reply({ status: 200, data: {}, repeat: 10 }),
mockapi.mock.artifacts.root.uploadMergedReport().reply({ status: 200, data: {}, repeat: 10 }),
mockapi.mock.artifacts.root.uploadLogsArchive().reply({ status: 200, data: {}, repeat: 10 }),
mockapi.mock.artifacts.root.presignUpload().reply({ status: 404, data: {}, repeat: 10 }),
mockapi.mock.artifacts.root.presignUploadPart().reply({ status: 404, data: {}, repeat: 10 }),
...extraMocks,
];
}
Expand Down
Loading