fix(check-workflows): mock action-artifacts capability probe endpoints#2450
Draft
matthiasL-scality wants to merge 2 commits into
Draft
fix(check-workflows): mock action-artifacts capability probe endpoints#2450matthiasL-scality wants to merge 2 commits into
matthiasL-scality wants to merge 2 commits into
Conversation
action-artifacts@4.3.0+ probes /presign-upload/ and /presign-upload-part/ before every upload to detect presigned/multipart capability. Without these nock intercepts the tests throw ERR_NOCK_NO_MATCH. Reply 404 so the action falls back to the standard upload path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ts@4.3.0 Pins the version used in workflow tests to 4.3.0 which includes the capability probe. This makes the check-workflows CI reproduce the ERR_NOCK_NO_MATCH failure and validate the probe mocks added in the previous commit. Revert to @v4 once action-artifacts 4.3.0+ is the stable tag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| body: [], | ||
| }, | ||
| }, | ||
| // action-artifacts@v4.5+ probes these endpoints before each upload to detect |
There was a problem hiding this comment.
Comment says @v4.5+ but the PR description says @4.3.0 introduced the probe (and the action is pinned to 4.3.0). Update the version reference to match.
Suggested change
| // action-artifacts@v4.5+ probes these endpoints before each upload to detect | |
| // action-artifacts@4.3.0+ probes these endpoints before each upload to detect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
action-artifacts@4.3.0 added a capability probe that fires a GET to
/presign-upload/capability-probe/probe.binand/presign-upload-part/capability-probe/probe.binbefore every upload, to detect presigned/multipart upload support. These endpoints are not yet deployed (pending PTFE-3137 and PTFE-3219).When
v4was pointed at 4.3.0, thecheck-workflowsCI broke withERR_NOCK_NO_MATCHbecause nock had no interceptor for the probe requests. The tag was rolled back as a temporary fix.Changes
Commit 1 — fix: Add
presignUploadandpresignUploadPartendpoints to theMockapidefinition inarchive-artifacts.spec.ts, and mock them with 404 incommonMockApi(). A 404 response makes the action fall back to the standard upload path, keeping existing tests valid.Commit 2 — test: Pin
archive-artifacts/action.yamltoaction-artifacts@4.3.0(the version with the probe) so thatcheck-workflowsCI actually reproduces the failure and validates the fix.How to validate on Monday
After PTFE-3137 and PTFE-3219 are merged and
action-artifactsis re-released:v4tag to the new release@v4