feat: support @argfile for rustc-fake - #2509
Merged
Merged
Conversation
ranger-ross
approved these changes
Jul 26, 2026
Kobzol
reviewed
Jul 27, 2026
Kobzol
left a comment
Kobzol
left a comment
Member
There was a problem hiding this comment.
Seems reasonable, thank you. Left one comment.
This PR includes * A verbatim copy of `arg_file_command.rs` from rust-lang/rust * adapted copies of some other helpers from bootstrap. This found because we tried to enable new build-dir layout for nightly in Cargo, but failed with ``` error: Unrecognized option: 'skip-this-rustc' ``` I _guess_ this was the root cause. See * https://triage.rust-lang.org/gha-logs/rust-lang/rust/89681531404 * rust-lang/rust#159857 (comment)
weihanglo
force-pushed
the
rustc-fake-argfile
branch
from
July 27, 2026 14:50
95e14fb to
94ee723
Compare
Kobzol
enabled auto-merge
July 27, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes
arg_file_command.rsfrom rust-lang/rustThis found because we tried to enable new build-dir layout for nightly
in Cargo, but failed with
I guess this was the root cause.
See