Update cargo submodule by weihanglo · Pull Request #159857 · rust-lang/rust

weihanglo · 2026-07-24T17:54:31Z

17 commits in 3efb1f477e99b42974b982d939fd100303cdf7db..54b61f13a4eea47ec3ee95237d4107976d7909ed
2026-07-17 23:53:19 +0000 to 2026-07-24 13:23:18 +0000

chore: bump to libgit2-sys@0.18.7+1.9.6 (chore: bump to libgit2-sys@0.18.7+1.9.6 cargo#17259)
Enable build-dir layout v2 on nightly by default (Enable build-dir layout v2 on nightly by default cargo#17258)
fix(path): clarify error message when path dependency has wrong package (fix(path): clarify error message when path dependency has wrong package cargo#16927)
fix(toml): warn on hyphenated lint names and duplicates (fix(toml): warn on hyphenated lint names and duplicates cargo#17051)
fix(test): gate trim-paths tests on split debuginfo support (fix(test): gate trim-paths tests on split debuginfo support cargo#17256)
test(git): Explicitly test for git injection attacks (test(git): Explicitly test for git injection attacks cargo#17253)
fix(git): Suggest libgit2 if git-cli fails (fix(git): Suggest libgit2 if git-cli fails cargo#17252)
fix(diag): bound transitive unused dependency traversal (fix(diag): bound transitive unused dependency traversal cargo#17251)
fix(git): Hide git fetch output without progress (fix(git): Hide git fetch output without progress cargo#17243)
revert(lint): Remove new_implicit_minimum_version_req (feat(lint): new implicit_minimum_version_req lint cargo#16321) (revert(lint): Remove new_implicit_minimum_version_req (#16321) cargo#17249)
fix: Add haiku's dylib path (fix: Add haiku's dylib path cargo#17248)
Zsh completion: Add -p and --package flags for cargo add (Zsh completion: Add -p and --package flags for cargo add cargo#17247)
refactor(source): Clarify the name of the remote git registry (refactor(source): Clarify the name of the remote git registry cargo#17240)
fix(timings): only report units the job queue actually ran (fix(timings): only report units the job queue actually ran cargo#17238)
Do not include proc-macro deps in rustc search path args (Do not include proc-macro deps in rustc search path args cargo#17236)
chore(deps): update cargo-semver-checks to v0.49.0 (chore(deps): update cargo-semver-checks to v0.49.0 cargo#17237)
rustdoc: rename the doc parts metadata params (rustdoc: rename the doc parts metadata params cargo#17234)

r? ghost

rustbot · 2026-07-24T17:54:34Z

Some changes occurred in src/tools/cargo

cc @ehuss

weihanglo · 2026-07-24T19:25:10Z

Need to update those rmake tests to reflect nightly build-dir layout changes.

rustbot · 2026-07-24T23:55:37Z

The run-make-support library was changed

cc @jieyouxu

weihanglo · 2026-07-24T23:59:26Z

r? ranger-ross

Mind reviewing 86a4c65 is good?

rustbot · 2026-07-25T00:00:57Z

⚠️ Warning ⚠️

Some commits in this PR modify submodules.

If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

weihanglo · 2026-07-25T00:03:23Z

+        let file_name = path.file_name().unwrap().to_str().unwrap();
+        file_name.starts_with("libcompiler_builtins") && file_name.ends_with(".rlib")
+    });
+    assert_eq!(rlibs.len(), 1, "expected exactly one compiler_builtins rlib: {rlibs:?}");


length assertion should guard us well to only get the one and only artifact.

View changes since the review

weihanglo · 2026-07-25T00:12:04Z

Or @jieyouxu if you are willing to take a look at the rmake change? 🥺

ranger-ross

Thanks!

View changes since this review

ranger-ross · 2026-07-25T02:52:31Z

-        .unwrap();
+    // The rlib file is emitted as an intermediate build artifacts.
+    // Do not hardcode the path.
+    let mut rlibs = recursive_find_files(&target_dir, |path| {


should we change this to target_dir.join("debug")?
If it's built in release mode we could end up finding the debug and release .rlibs and hit the assert below.
Not sure if that is applicable for run-make tests

View changes since the review

Good point. Updated.

Cargo enables build-dir layout v2 by default on nightly (rust-lang/cargo PR 17258). Intermediate build artifacts no longer live in `<target-dir>/<triple>/<profile>/deps/` but in per-unit `build/<pkg>/<hash>/out/` directories.

weihanglo · 2026-07-25T03:28:37Z

Okay. Going to merge this.

@bors r=ranger-ross p=1 rollup=never

If the remake test changes are bad, please call them out!

rust-bors · 2026-07-25T03:28:40Z

📌 Commit 3e3b43c has been approved by ranger-ross

It is now in the queue for this repository.

jieyouxu · 2026-07-25T05:53:00Z

If the remake test changes are bad, please call them out!

No they look fine, cheers

Update cargo submodule 17 commits in 3efb1f477e99b42974b982d939fd100303cdf7db..54b61f13a4eea47ec3ee95237d4107976d7909ed 2026-07-17 23:53:19 +0000 to 2026-07-24 13:23:18 +0000 - chore: bump to `libgit2-sys@0.18.7+1.9.6` (rust-lang/cargo#17259) - Enable build-dir layout v2 on nightly by default (rust-lang/cargo#17258) - fix(path): clarify error message when path dependency has wrong package (rust-lang/cargo#16927) - fix(toml): warn on hyphenated lint names and duplicates (rust-lang/cargo#17051) - fix(test): gate trim-paths tests on split debuginfo support (rust-lang/cargo#17256) - test(git): Explicitly test for git injection attacks (rust-lang/cargo#17253) - fix(git): Suggest libgit2 if git-cli fails (rust-lang/cargo#17252) - fix(diag): bound transitive unused dependency traversal (rust-lang/cargo#17251) - fix(git): Hide git fetch output without progress (rust-lang/cargo#17243) - revert(lint): Remove `new_implicit_minimum_version_req` (rust-lang/cargo#16321) (rust-lang/cargo#17249) - fix: Add haiku's dylib path (rust-lang/cargo#17248) - Zsh completion: Add `-p` and `--package` flags for `cargo add` (rust-lang/cargo#17247) - refactor(source): Clarify the name of the remote git registry (rust-lang/cargo#17240) - fix(timings): only report units the job queue actually ran (rust-lang/cargo#17238) - Do not include proc-macro deps in rustc search path args (rust-lang/cargo#17236) - chore(deps): update cargo-semver-checks to v0.49.0 (rust-lang/cargo#17237) - rustdoc: rename the doc parts metadata params (rust-lang/cargo#17234) r? ghost

rust-bors · 2026-07-25T12:22:15Z

💔 Test for 2799e29 failed: CI. Failed job:

auto - x86_64-msvc-ext3 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-07-25T12:29:42Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

weihanglo · 2026-07-25T12:49:17Z

Run src/ci/scripts/install-wix.sh
curl: (35) Recv failure: Connection was reset

@bors retry

jieyouxu · 2026-07-25T13:06:24Z

githubstatus says outage was mitigated
@bors p=1000

rust-bors · 2026-07-25T13:06:53Z

⌛ Testing commit 3e3b43c with merge d0f85c2...

Workflow: https://github.com/rust-lang/rust/actions/runs/30159129661

Update cargo submodule 17 commits in 3efb1f477e99b42974b982d939fd100303cdf7db..54b61f13a4eea47ec3ee95237d4107976d7909ed 2026-07-17 23:53:19 +0000 to 2026-07-24 13:23:18 +0000 - chore: bump to `libgit2-sys@0.18.7+1.9.6` (rust-lang/cargo#17259) - Enable build-dir layout v2 on nightly by default (rust-lang/cargo#17258) - fix(path): clarify error message when path dependency has wrong package (rust-lang/cargo#16927) - fix(toml): warn on hyphenated lint names and duplicates (rust-lang/cargo#17051) - fix(test): gate trim-paths tests on split debuginfo support (rust-lang/cargo#17256) - test(git): Explicitly test for git injection attacks (rust-lang/cargo#17253) - fix(git): Suggest libgit2 if git-cli fails (rust-lang/cargo#17252) - fix(diag): bound transitive unused dependency traversal (rust-lang/cargo#17251) - fix(git): Hide git fetch output without progress (rust-lang/cargo#17243) - revert(lint): Remove `new_implicit_minimum_version_req` (rust-lang/cargo#16321) (rust-lang/cargo#17249) - fix: Add haiku's dylib path (rust-lang/cargo#17248) - Zsh completion: Add `-p` and `--package` flags for `cargo add` (rust-lang/cargo#17247) - refactor(source): Clarify the name of the remote git registry (rust-lang/cargo#17240) - fix(timings): only report units the job queue actually ran (rust-lang/cargo#17238) - Do not include proc-macro deps in rustc search path args (rust-lang/cargo#17236) - chore(deps): update cargo-semver-checks to v0.49.0 (rust-lang/cargo#17237) - rustdoc: rename the doc parts metadata params (rust-lang/cargo#17234) r? ghost

weihanglo self-assigned this Jul 24, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2026

This comment has been minimized.

Sign in to view

weihanglo force-pushed the update-cargo branch from 3cd97f8 to 3b5903b Compare July 24, 2026 23:55

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2026

This comment has been minimized.

Sign in to view

weihanglo force-pushed the update-cargo branch from 3b5903b to 8d38889 Compare July 24, 2026 23:57

This comment has been minimized.

Sign in to view

rustbot assigned ranger-ross and unassigned weihanglo Jul 24, 2026

weihanglo force-pushed the update-cargo branch from 8d38889 to 778f0d7 Compare July 25, 2026 00:00

weihanglo commented Jul 25, 2026

View reviewed changes

weihanglo force-pushed the update-cargo branch from 778f0d7 to b7f7fa1 Compare July 25, 2026 00:06

ranger-ross approved these changes Jul 25, 2026

View reviewed changes

ranger-ross reviewed Jul 25, 2026

View reviewed changes

jieyouxu self-assigned this Jul 25, 2026

weihanglo added 2 commits July 24, 2026 23:14

test(run-make): find cargo artifacts recursively

96d104c

Cargo enables build-dir layout v2 by default on nightly (rust-lang/cargo PR 17258). Intermediate build artifacts no longer live in `<target-dir>/<triple>/<profile>/deps/` but in per-unit `build/<pkg>/<hash>/out/` directories.

Update cargo submodule

3e3b43c

weihanglo force-pushed the update-cargo branch from b7f7fa1 to 3e3b43c Compare July 25, 2026 03:14

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 25, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2026

jieyouxu removed their assignment Jul 25, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2026

rust-bors Bot mentioned this pull request Jul 25, 2026

document #[global_allocator] constraints #159720

Open

Uh oh!

Uh oh!

Conversation

weihanglo commented Jul 24, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

weihanglo commented Jul 24, 2026

Uh oh!

rustbot commented Jul 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

weihanglo commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 25, 2026

Uh oh!

weihanglo Jul 25, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weihanglo commented Jul 25, 2026

Uh oh!

ranger-ross left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ranger-ross Jul 25, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weihanglo Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

weihanglo commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 25, 2026

Uh oh!

jieyouxu commented Jul 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 25, 2026

Uh oh!

rust-log-analyzer commented Jul 25, 2026

Uh oh!

weihanglo commented Jul 25, 2026

Uh oh!

jieyouxu commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

weihanglo commented Jul 24, 2026 •

edited by rustbot

Loading

weihanglo commented Jul 24, 2026 •

edited

Loading

weihanglo Jul 25, 2026 •

edited by rustbot

Loading

ranger-ross left a comment •

edited by rustbot

Loading

ranger-ross Jul 25, 2026 •

edited by rustbot

Loading

rust-bors Bot commented Jul 25, 2026 •

edited

Loading