Repository navigation
fix(css): remove dangling requires and handle CSS extensions in chunk names - #1114
Merged
Merged
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
sxzzbot
marked this pull request as ready for review
November 2, 2026 06:38
sxzz
approved these changes
Nov 2, 2026
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI usage
Description
With
unbundle: true, CJS output kept arequire()to a removed pure CSS chunk, so it couldn't be loaded. This removes it, following Vite'sgetEmptyChunkReplacer.It also prepares for rolldown/rolldown#11410, which keeps non-JS extensions in
[name](card.css.cjs). Without thetoCssFileNamechange, that Rolldown emitscard.css.css. Published tsdown allows it through~1.2.15, so this should ship before the next Rolldown release.Linked Issues
Refs #912
The
Card2.cjsname goes away with rolldown/rolldown#11410, so #912 can be closed after that upgrade.Additional context
Alternative to #1077. Tested against both Rolldown 1.2.15 and
pkg.pr.new/rolldown@main. Upgrading Rolldown will need updates to thecss > unbundleandunbundle > base dirsnapshots and the JSON Schema.