Repository navigation
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and the changes include targeted regression coverage.
Pull request overview
Fixes dangling CommonJS require calls left by removed pure CSS chunks.
Changes:
- Adds path-aware AST replacement for CSS requires.
- Preserves unrelated requires and source offsets.
- Expands unit and integration coverage, including minified output.
File summaries
| File | Description |
|---|---|
tests/utils.ts |
Adds output inspection and runtime helpers. |
tests/css.test.ts |
Adds CSS and unbundle integration coverage. |
packages/css/src/pure-chunk.ts |
Removes dangling CSS imports and requires. |
packages/css/src/pure-chunk.test.ts |
Tests replacement behavior and edge cases. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep the upstream lint directive and the CJS runtime helper import when merging main into the CSS fix branch. Fixes rolldown#1075
|
Merged
Four CSS regression cases fail with upstream's chunk removal code. All six selected cases pass with this fix. AI-assisted: Codex prepared this merge and ran the checks. |
|
Superseded by #1114, which was merged. It removes the |
AI usage
Description
Remove side-effect CommonJS
requirecalls that point to deleted pure CSS chunks so unbundled entries importing CSS can be loaded. Add coverage for minified output, short paths, and unrelated calls that must remain unchanged.Linked Issues
Fixes #1075, Fixes #912
Additional context
CSS, unbundle, and helper tests: 119 passed, 3 expected failures. Lint and typecheck passed.
Baseline and candidate checks on Weco (retrospective record).