Skip to content

Fix settings test and remove deprecated defaultActionGroup #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbdelrhmanSaid merged 1 commit into from
Aug 21, 2026
Merged

Fix settings test and remove deprecated defaultActionGroup #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Datatables/src/Datatable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,16 +177,6 @@ public function actions(): array
return [];
}

/**
* Get the default action group for the datatable.
*
* @deprecated Use ActionGroup::auto() instead.
*/
public static function defaultActionGroup(array $actions, ?string $label = null, ?string $icon = null): array
{
return ActionGroup::auto($actions, $label, $icon);
}

/**
* Get the bulk actions for the datatable.
*/
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Core/Models/SettingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

it('returns the configured default for a key including nested dot paths', function () {
expect(Setting::default('theme.primary'))->toBe('blue')
->and(Setting::default('app_name.en'))->toBe('Dashboard')
->and(Setting::default('app_name.en'))->toBe('Nexus')
->and(Setting::default('missing'))->toBeNull();
});

Expand Down
Loading