Fix settings test and remove deprecated defaultActionGroup - #25
Merged
AbdelrhmanSaid merged 1 commit intoAug 21, 2026
Merged
Conversation
Update the nested app_name default expectation to match the current Nexus config value, and remove the deprecated Datatable::defaultActionGroup wrapper now that ActionGroup::auto is the public API. Co-authored-by: Abdelrhman Said <AbdelrhmanSaid@users.noreply.github.com>
AbdelrhmanSaid
marked this pull request as ready for review
August 21, 2026 13:31
AbdelrhmanSaid
deleted the
cursor/fix-setting-test-remove-default-action-group-5ac8
branch
August 21, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings test still expected the old
app_name.endefault (Dashboard) after the config was updated toNexus, which is the only failing test on master.This also removes the deprecated
Datatable::defaultActionGroup()wrapper. Callers should useActionGroup::auto()instead, which is already the documented and generated-stub API.Changes
Setting::default('app_name.en')assertion to matchconfig/redot.phpDatatable::defaultActionGroup()Compatibility
Removing
defaultActionGroupis a breaking change for any consuming dashboard that still calls it. The replacement isActionGroup::auto($actions, $label, $icon).