Skip to content

[perf] Skip native type resolution in SimplifyBoolIdenticalTrueRector unless true/false literal present #8578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 10, 2026
Merged

[perf] Skip native type resolution in SimplifyBoolIdenticalTrueRector unless true/false literal present #8578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions rules/CodeQuality/Rector/Identical/SimplifyBoolIdenticalTrueRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,17 @@ public function getNodeTypes(): array
*/
public function refactor(Node $node): ?Node
{
if ($this->isBooleanButNotTrueAndFalse($node->left)) {
return $this->processBoolTypeToNotBool($node, $node->left, $node->right);
// the rule only applies when one side is a true/false constant;
// check it first to avoid the expensive native type resolution below
if ($this->valueResolver->isTrueOrFalse($node->right)) {
if ($this->isBooleanButNotTrueAndFalse($node->left)) {
return $this->processBoolTypeToNotBool($node, $node->left, $node->right);
}

return null;
}

if ($this->isBooleanButNotTrueAndFalse($node->right)) {
if ($this->valueResolver->isTrueOrFalse($node->left) && $this->isBooleanButNotTrueAndFalse($node->right)) {
return $this->processBoolTypeToNotBool($node, $node->right, $node->left);
}

Expand Down
Loading