Repository navigation
[perf] Skip native type resolution in SimplifyBoolIdenticalTrueRector unless true/false literal present - #8578
Merged
Conversation
… unless a true/false literal is present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimplifyBoolIdenticalTrueRector ran
getNativeType()on both sides of every===/!==node, even though it can only fire when one side is a literaltrue/false.Most identical comparisons in real code compare against non-bool operands (
$a === $b,=== null,=== 0), so the type resolution was pure overhead.Reorder: check the cheap
isTrueOrFalse()on the opposite operand first, and only run the expensive native type resolution when a bool literal is actually present. Behavior unchanged - all existing cases ($b === true,true === $b,!$x === false, both-literal) resolve identically.