Skip to content

[Actions] Redesign the Windows build to automatically find the proper devenv#501

Merged
VeithMetro merged 1 commit into
masterfrom
development/actions-windows
Jun 12, 2026
Merged

[Actions] Redesign the Windows build to automatically find the proper devenv#501
VeithMetro merged 1 commit into
masterfrom
development/actions-windows

Conversation

@VeithMetro

Copy link
Copy Markdown
Contributor

No description provided.

Refactor build commands to use a loop for project builds.
Copilot AI review requested due to automatic review settings June 10, 2026 07:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows GitHub Actions workflow to stop hardcoding the Visual Studio devenv path and instead discover it dynamically at runtime, making the build more resilient to runner image changes.

Changes:

  • Removed the hardcoded devEnv path from workflow env.
  • Added a vswhere.exe-based lookup to find the installed Visual Studio path and derive devenv.com.
  • Simplified project builds by looping over the project list and failing fast on build errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/Build ThunderInterfaces on Windows.yml
@VeithMetro VeithMetro requested a review from sebaszm June 11, 2026 06:36
@VeithMetro VeithMetro merged commit 5dff226 into master Jun 12, 2026
65 checks passed
@VeithMetro VeithMetro deleted the development/actions-windows branch June 12, 2026 06:16
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants