Skip to content

refactor(interfaces): IERC4626Minimal inherits IERC20MetadataMinimal, eliminating redundant decimals() #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedavidmeister wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(interfaces): IERC4626Minimal inherits IERC20MetadataMinimal, eliminating redundant decimals() #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/lib/erc4626/LibERC4626.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,23 @@ pragma solidity ^0.8.25;

import {LibDecimalFloat, Float} from "rain-math-float-0.1.1/src/lib/LibDecimalFloat.sol";

/// @dev Minimal ERC-4626 interface covering only the conversion functions and
/// metadata needed by the Rain words.
interface IERC4626Minimal {
/// @dev Minimal ERC-20 metadata interface for reading a token's decimal
/// precision. Used for the underlying asset and, via IERC4626Minimal, for the
/// vault share token itself.
interface IERC20MetadataMinimal {
function decimals() external view returns (uint8);
}

/// @dev Minimal ERC-4626 interface covering only the conversion functions and
/// metadata needed by the Rain words. Inherits decimals() from
/// IERC20MetadataMinimal, reflecting that every ERC-4626 vault is also an
/// ERC-20 token.
interface IERC4626Minimal is IERC20MetadataMinimal {
function asset() external view returns (address);
function convertToAssets(uint256 shares) external view returns (uint256 assets);
function convertToShares(uint256 assets) external view returns (uint256 shares);
}

/// @dev Minimal ERC-20 metadata interface for reading the underlying asset's
/// decimal precision.
interface IERC20MetadataMinimal {
function decimals() external view returns (uint8);
}

/// @title LibERC4626
/// @notice Core library for interacting with ERC-4626 tokenised vaults on-chain.
/// Handles conversion between the float representation used by the Rain interpreter
Expand Down
Loading