Skip to content

refactor(interfaces): IERC4626Minimal inherits IERC20MetadataMinimal, eliminating redundant decimals()#239

Open
thedavidmeister wants to merge 1 commit into
mainfrom
issue-78-ierc20metadata-leaky
Open

refactor(interfaces): IERC4626Minimal inherits IERC20MetadataMinimal, eliminating redundant decimals()#239
thedavidmeister wants to merge 1 commit into
mainfrom
issue-78-ierc20metadata-leaky

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Summary

  • IERC4626Minimal previously declared decimals() directly, duplicating the same signature already in IERC20MetadataMinimal
  • Now IERC4626Minimal is IERC20MetadataMinimal, so decimals() is declared exactly once, reflecting that every ERC-4626 vault is also an ERC-20 token
  • No logic change: vault.decimals() and IERC20MetadataMinimal(vault.asset()).decimals() both work as before
  • Interface declarations reordered: IERC20MetadataMinimal first (the base), then IERC4626Minimal is IERC20MetadataMinimal

Closes #78

Test plan

  • forge test — 123 tests passed, 0 failed, 0 skipped

Co-Authored-By: Claude noreply@anthropic.com

… removing redundant decimals()

Closes #78

Co-Authored-By: Claude <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable usage-based reviews in Billing to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information, and refer to the rate limits docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0ad835e9-c3d4-4bbe-9e9c-e404851dd60d

📥 Commits

Reviewing files that changed from the base of the PR and between 7415942 and 330360f.

📒 Files selected for processing (1)
  • src/lib/erc4626/LibERC4626.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-78-ierc20metadata-leaky

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant decimals() declared in two interfaces; IERC20MetadataMinimal is leaky

1 participant