refactor(interfaces): IERC4626Minimal inherits IERC20MetadataMinimal, eliminating redundant decimals()#239
refactor(interfaces): IERC4626Minimal inherits IERC20MetadataMinimal, eliminating redundant decimals()#239thedavidmeister wants to merge 1 commit into
Conversation
… removing redundant decimals() Closes #78 Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 15 minutes Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable usage-based reviews in Billing to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information, and refer to the rate limits docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
IERC4626Minimalpreviously declareddecimals()directly, duplicating the same signature already inIERC20MetadataMinimalIERC4626Minimal is IERC20MetadataMinimal, sodecimals()is declared exactly once, reflecting that every ERC-4626 vault is also an ERC-20 tokenvault.decimals()andIERC20MetadataMinimal(vault.asset()).decimals()both work as beforeIERC20MetadataMinimalfirst (the base), thenIERC4626Minimal is IERC20MetadataMinimalCloses #78
Test plan
forge test— 123 tests passed, 0 failed, 0 skippedCo-Authored-By: Claude noreply@anthropic.com