Skip to content

Open the Attended Session on Cloning a Private Hub Checkout - #3648

Merged
ptr727 merged 4 commits into
developfrom
feature/auto-3604
Oct 30, 2026
Merged

ptr727 merged 4 commits into
developfrom
feature/auto-3604

Conversation

@ptr727

@ptr727 ptr727 commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • session-handoff "The Attended Session" gains a step 0: clone the hub's main into a new directory under the fleet worktree directory as the session's first command, with the command in the step. That clone is the checkout $handoff runs from, and it is pulled fast-forward before step 6 writes.
  • Step 0 says that wherever the skill was loaded from is never the session's hub checkout, and leaves task worktrees off a base clone to repo-worktree.
  • "Running the Chain" now says <hub-checkout> is a hub checkout of the session's own, never the maintainer's, and drops the in-hub relative-path exception.
  • unattended-handoff "The Seats" stops citing that removed exception, and says a seat clones its own hub checkout on main the way step 0 does.
  • Distributions regenerated with scripts/build_dist.py.

Where a private checkout lives long-term and who removes it stays #3330's subject, closed under the decision on #3391. This change is about when the clone is made.

Closes on promotion: #3604

Local pass findings

The two introduced findings the first push listed, the orchestrator being named as a cloning seat and Picker step 6 forbidding the picker's own clone, are fixed in 9e0a7de. A further pass over that commit raised none.

Each unattended round now leaves a picker clone and a worker clone under the fleet worktree directory. Removing them is the subject #3330 named, closed under the decision on #3391, so this change sets none.

🤖 Generated with Claude Code

ptr727 and others added 3 commits October 30, 2026 00:58
The attended procedure's first command ran `$handoff` from a hub checkout it
never said to make, so a resuming session took the Skill tool's base
directory, the maintainer's own checkout, as that checkout. Step 0 now clones
the hub's main as the session's first command and names that clone as the one
`$handoff` runs from. "Running the Chain" says the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name the step 0 clone so it never takes a task worktree's path, and pull it
before step 6 writes. State that wherever the skill loaded from is not the
session's hub checkout, without claiming what that location is. Drop the
in-hub relative-path exception the unattended seats still cited.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Define `<worktrees>` in step 0 again, and have each unattended seat clone
its own hub checkout on main the same way, since neither its feature-branch
worktree nor the launch checkout qualifies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 30, 2026 08:04
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptr727

ptr727 commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head def0b14b20d378528b2086d291b9b01457141e4c, the content this pull request carries at that commit against develop, and it recorded 2 findings.

The orchestrator runs one command and never the chain's script, so only
the picker and the worker clone a hub checkout. The picker's write limit
now names its own clone beside the handoff it creates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 9e0a7def02915c64a0999812fc9fec4d0f760665, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active P1 issue remains because the clone requirement incorrectly includes the orchestrator and conflicts with its one-command contract.

1 open issue
What changed in this PR

This pull request updates attended and unattended handoff workflows to create session-owned hub checkouts from main, and regenerates the GitHub and Claude skill distributions.

Changes:

  • Adds an initial attended-session clone step and fast-forward refresh before handoff writes.
  • Clarifies that $handoff uses the session's private hub checkout.
  • Updates unattended picker and worker checkout guidance.
  • Regenerates distributed skills and source digests.
  • An unresolved instruction incorrectly includes the orchestrator in the clone requirement.

This pull request requires changes.

File Description
.github/​skills/​unattended-handoff/​SKILL.md Generated GitHub distribution of unattended-handoff changes.
.github/​skills/​session-handoff/​SKILL.md Generated GitHub distribution of session-handoff changes.
.claude-plugin/​fleet-skills/​skills/​unattended-handoff/​SKILL.md Generated Claude distribution of unattended-handoff changes.
.claude-plugin/​fleet-skills/​skills/​session-handoff/​SKILL.md Generated Claude distribution of session-handoff changes.
.claude-plugin/​fleet-skills/​.source-digests/​unattended-handoff Updated unattended-handoff source digest.
.claude-plugin/​fleet-skills/​.source-digests/​session-handoff Updated session-handoff source digest.
.agents/​skills/​unattended-handoff/​SKILL.md Updates unattended seat checkout requirements.
.agents/​skills/​session-handoff/​SKILL.md Adds the attended-session hub clone step and updates handoff paths.

Review effort: Lite

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.70%. Comparing base (b38e084) to head (9e0a7de).
⚠️ Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3648      +/-   ##
===========================================
+ Coverage    81.60%   81.70%   +0.09%     
===========================================
  Files           26       26              
  Lines         9070     9119      +49     
===========================================
+ Hits          7402     7451      +49     
  Misses        1668     1668              
Flag Coverage Δ
python-3.13 81.70% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 64a1575 into develop Oct 30, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/auto-3604 branch October 30, 2026 08:51
ptr727 added a commit that referenced this pull request Oct 30, 2026
…Session Prompt Rules (#3667)

Promotes the changes merged into `develop` since promotion #3636 to
`main`.

- [#3640](#3640) Pins the
validator's `uvx ruff` to a Dependabot-managed manifest.
- [#3642](#3642) Counts
Copilot findings under the unresolved bullet and the file table.
- [#3644](#3644) Aligns
the split comment copies and drops the stale counts.
- [#3646](#3646) Sends a
command meant for the session's input line in a plain message, never in
a blocking prompt.
- [#3648](#3648) Opens the
attended session by cloning a hub checkout of the session's own.
- [#3650](#3650) Reads a
held package as installed in both Linux host scripts.
- [#3652](#3652) States
the PowerShell `-Help` and `-h` form in the command-line argument rules.
- [#3654](#3654) Counts
sentences in Markdown table cells for the sentence-length check.
- [#3658](#3658) Splits a
table row only at an unescaped pipe in the semicolon rule.
- [#3660](#3660) Finds
table cell boundaries before blanking code spans and quotations.
- [#3662](#3662) Names a
stale job record on a completed run in `pr_review.py`.
- [#3665](#3665) Keeps a
line holding code after a block comment's closer out of `comment-added`.
Its squash commit on `develop` carries the pull request's original
title, which names a heredoc reading. That reading was withdrawn before
the merge on decision #3666, so a workflow `run:` heredoc body still
reads as code.
- [#3669](#3669) Counts
each `[Pn]` marker in a Copilot Findings cell, so a second finding in
one cell is no longer dropped from triage. It answers one of the two
findings Copilot raised on this promotion. The other is declined with a
parser probe in its thread.

Closes #3616
Closes #3610
Closes #3622
Closes #3638
Closes #3604
Closes #3511
Closes #3602
Closes #3456
Closes #3655
Closes #3657
Closes #3362
Closes #1664

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants