docs(skills): use typed plivo sip commands in the SIP trunking skill - #96
Open
Ayush Anand Plivo (ayush-git-plivo) wants to merge 1 commit into
Open
Ayush Anand Plivo (ayush-git-plivo) wants to merge 1 commit into
Ayush Anand Plivo (ayush-git-plivo) wants to merge 1 commit into
Conversation
The bundled sip-trunking skill still said "The CLI has no trunk commands", "no `plivo sip ...`" and "no `numbers update --trunk-id`", and sent every trunk, URI, credential and IP list step through raw `plivo api` calls. All of that shipped in v1.1.0, so an agent following the skill avoided the commands that validate input locally and read passwords from stdin only. - Readiness check, stages 2 to 5, go-live, debugging and the object reference now use `plivo sip trunks|uris|credentials|ip-acl|calls` and `numbers update --trunk-id`. - `plivo api` stays for call Insights (no typed command yet) and as a labelled fallback, with the request bodies kept for fields no flag covers. - `sip calls diagnose` replaces the note that `voice calls diagnose` might not accept trunk calls, including its server-side limitation. - Adds xAI Voice Agents (inbound only, `sip.voice.x.ai;transport=tls`), which now has a Plivo SIP trunking guide. - Points to `plivo skill install voice-xml|audio-streaming|cli` instead of `npx skills add` for the other skills. Every `plivo sip` command and flag named in the skill was checked against the v1.1.2 help output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bundled
sip-trunkingskill still told agents "The CLI has no trunk commands", "noplivo sip ..." and "nonumbers update --trunk-id", and routed every step through rawplivo api POST /Zentrunk/...calls (35 of them). All of that shipped in v1.1.0. An agent following the skill avoided the commands that validate input locally and read passwords from stdin only.Changes
plivo sip trunks|uris|credentials|ip-acl|callsandnumbers update --trunk-id.--password-stdin(printf '%s' "$SIP_PASSWORD" | plivo sip credentials create ...), matching the CLI.plivo apistays only for call Insights (no typed command yet) and as a labelled fallback; the per-platform request bodies are kept for fields no flag covers.plivo sip calls diagnosereplaces the note thatvoice calls diagnosemight not accept trunk calls, including its server-side limitation.sip.voice.x.ai;transport=tls), which now has a Plivo SIP trunking guide; the skill previously said Plivo had no xAI guide.plivo skill install voice-xml|audio-streaming|cliinstead ofnpx skills addfor the other skills.Breaking change?
Testing
go build ./...go test ./... -racegofmt -l .is cleanplivo sipcommand named in the skill was checked against its v1.1.2--helpusage line (not the exit code, since unknown subcommands currently exit 0 on--help), and every flag the skill uses appears in the matching command's help.Follow-up for the docs: once this ships, the SIP "Build with an AI coding agent" page can say the skill uses the
plivo sipcommands (plivo-dev/docs#173 covers the login note only).🤖 Generated with Claude Code