-
Notifications
You must be signed in to change notification settings - Fork 122
Add octavia service to SKMO central and leaf regions #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vakwetu
wants to merge
1
commit into
openstack-k8s-operators:main
Choose a base branch
from
vakwetu:add-octavia-to-skmo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
examples/va/multi-namespace-skmo/components/metallb-ctlplane-bridge/kustomization.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| # SKMO uses linux-bridge ospbr for ctlplane (NNCP). MetalLB must announce VIPs on | ||
| # the bridge, not the raw NIC (enp7s0), or EDPM nodes cannot reach dnsmasq UDP/53. | ||
| apiVersion: kustomize.config.k8s.io/v1alpha1 | ||
| kind: Component | ||
|
|
||
| patches: | ||
| - target: | ||
| group: metallb.io | ||
| kind: L2Advertisement | ||
| name: ctlplane | ||
| patch: |- | ||
| - op: replace | ||
| path: /spec/interfaces/0 | ||
| value: ospbr | ||
| - target: | ||
| group: metallb.io | ||
| kind: L2Advertisement | ||
| name: ctlplane2 | ||
| patch: |- | ||
| - op: replace | ||
| path: /spec/interfaces/0 | ||
| value: ospbr2 |
57 changes: 57 additions & 0 deletions
57
...les/va/multi-namespace-skmo/components/octavia-edpm-bridge/edpm-octavia-ansible-vars.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: edpm-nodeset-values | ||
| data: | ||
| nodeset: | ||
| ansible: | ||
| ansibleVars: | ||
| edpm_ovn_bridge_mappings: | ||
| - "datacentre:br-ex" | ||
| - "octavia:octbr" | ||
| edpm_network_config_template: | | ||
| --- | ||
| {% set mtu_list = [ctlplane_mtu] %} | ||
| {% for network in nodeset_networks %} | ||
| {% set _ = mtu_list.append(lookup('vars', networks_lower[network] ~ '_mtu')) %} | ||
| {%- endfor %} | ||
| {% set min_viable_mtu = mtu_list | max %} | ||
| network_config: | ||
| - type: interface | ||
| name: nic1 | ||
| use_dhcp: true | ||
| mtu: {{ min_viable_mtu }} | ||
| - type: ovs_bridge | ||
| name: {{ neutron_physical_bridge_name }} | ||
| mtu: {{ min_viable_mtu }} | ||
| use_dhcp: false | ||
| dns_servers: {{ ctlplane_dns_nameservers }} | ||
| domain: {{ dns_search_domains }} | ||
| addresses: | ||
| - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_cidr }} | ||
| routes: {{ ctlplane_host_routes }} | ||
| members: | ||
| - type: interface | ||
| name: nic2 | ||
| mtu: {{ min_viable_mtu }} | ||
| # force the MAC address of the bridge to this interface | ||
| primary: true | ||
| {% for network in nodeset_networks %} | ||
| - type: vlan | ||
| mtu: {{ lookup('vars', networks_lower[network] ~ '_mtu') }} | ||
| vlan_id: {{ lookup('vars', networks_lower[network] ~ '_vlan_id') }} | ||
| addresses: | ||
| - ip_netmask: | ||
| {{ lookup('vars', networks_lower[network] ~ '_ip') }}/{{ lookup('vars', networks_lower[network] ~ '_cidr') }} | ||
| routes: {{ lookup('vars', networks_lower[network] ~ '_host_routes') }} | ||
| {% endfor %} | ||
| - type: ovs_bridge | ||
| name: octbr | ||
| mtu: {{ min_viable_mtu }} | ||
| use_dhcp: false | ||
| members: | ||
| - type: vlan | ||
| mtu: {{ min_viable_mtu }} | ||
| vlan_id: 23 | ||
| device: nic2 |
10 changes: 10 additions & 0 deletions
10
examples/va/multi-namespace-skmo/components/octavia-edpm-bridge/kustomization.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| # OVN Octavia compute bridge overlay for EDPM nodesets. | ||
| apiVersion: kustomize.config.k8s.io/v1alpha1 | ||
| kind: Component | ||
|
|
||
| patches: | ||
| - target: | ||
| kind: ConfigMap | ||
| name: edpm-nodeset-values | ||
| path: edpm-octavia-ansible-vars.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
examples/va/multi-namespace-skmo/control-plane/networking/kustomization.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - ../../../multi-namespace/control-plane/networking | ||
| - octavia-netattach.yaml | ||
|
|
||
| components: | ||
| - ../../components/metallb-ctlplane-bridge | ||
| - ../../../../../va/multi-namespace-skmo/networking-octavia |
170 changes: 170 additions & 0 deletions
170
examples/va/multi-namespace-skmo/control-plane/networking/nncp/kustomization.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,170 @@ | ||
| --- | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| # ci_gen_kustomize_values writes env-specific network-values to the base | ||
| # values.yaml before build (see automation vars src_file). | ||
| resources: | ||
| - ../../../../multi-namespace/control-plane/networking/nncp | ||
|
|
||
| components: | ||
| - ../../../../../../va/multi-namespace-skmo/octavia-network-values | ||
|
|
||
| # Octavia NNCP patches for SKMO. Select by osp/nncp-node label so patches apply | ||
| # after lib/nncp-single-nic renames node-0 -> ostest-master-0. | ||
| patches: | ||
| - target: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-0 | ||
| patch: |- | ||
| - op: add | ||
| path: /spec/desiredState/interfaces/- | ||
| value: | ||
| description: Octavia vlan host interface | ||
| name: octavia | ||
| state: up | ||
| type: vlan | ||
| vlan: | ||
| base-iface: _replaced_ | ||
| id: _replaced_ | ||
| - target: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-0 | ||
| patch: |- | ||
| - op: add | ||
| path: /spec/desiredState/interfaces/- | ||
| value: | ||
| description: Octavia bridge | ||
| mtu: 1500 | ||
| name: octbr | ||
| type: linux-bridge | ||
| bridge: | ||
| options: | ||
| stp: | ||
| enabled: false | ||
| port: | ||
| - name: octavia | ||
| - target: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-1 | ||
| patch: |- | ||
| - op: add | ||
| path: /spec/desiredState/interfaces/- | ||
| value: | ||
| description: Octavia vlan host interface | ||
| name: octavia | ||
| state: up | ||
| type: vlan | ||
| vlan: | ||
| base-iface: _replaced_ | ||
| id: _replaced_ | ||
| - target: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-1 | ||
| patch: |- | ||
| - op: add | ||
| path: /spec/desiredState/interfaces/- | ||
| value: | ||
| description: Octavia bridge | ||
| mtu: 1500 | ||
| name: octbr | ||
| type: linux-bridge | ||
| bridge: | ||
| options: | ||
| stp: | ||
| enabled: false | ||
| port: | ||
| - name: octavia | ||
| - target: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-2 | ||
| patch: |- | ||
| - op: add | ||
| path: /spec/desiredState/interfaces/- | ||
| value: | ||
| description: Octavia vlan host interface | ||
| name: octavia | ||
| state: up | ||
| type: vlan | ||
| vlan: | ||
| base-iface: _replaced_ | ||
| id: _replaced_ | ||
| - target: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-2 | ||
| patch: |- | ||
| - op: add | ||
| path: /spec/desiredState/interfaces/- | ||
| value: | ||
| description: Octavia bridge | ||
| mtu: 1500 | ||
| name: octbr | ||
| type: linux-bridge | ||
| bridge: | ||
| options: | ||
| stp: | ||
| enabled: false | ||
| port: | ||
| - name: octavia | ||
|
|
||
| replacements: | ||
| - source: | ||
| kind: ConfigMap | ||
| name: octavia-network-values | ||
| fieldPath: data.octavia.base_iface | ||
| targets: | ||
| - select: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-0 | ||
| fieldPaths: | ||
| - spec.desiredState.interfaces.[name=octavia].vlan.base-iface | ||
| - source: | ||
| kind: ConfigMap | ||
| name: octavia-network-values | ||
| fieldPath: data.octavia.vlan | ||
| targets: | ||
| - select: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-0 | ||
| fieldPaths: | ||
| - spec.desiredState.interfaces.[name=octavia].vlan.id | ||
| - source: | ||
| kind: ConfigMap | ||
| name: octavia-network-values | ||
| fieldPath: data.octavia.base_iface | ||
| targets: | ||
| - select: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-1 | ||
| fieldPaths: | ||
| - spec.desiredState.interfaces.[name=octavia].vlan.base-iface | ||
| - source: | ||
| kind: ConfigMap | ||
| name: octavia-network-values | ||
| fieldPath: data.octavia.vlan | ||
| targets: | ||
| - select: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-1 | ||
| fieldPaths: | ||
| - spec.desiredState.interfaces.[name=octavia].vlan.id | ||
| - source: | ||
| kind: ConfigMap | ||
| name: octavia-network-values | ||
| fieldPath: data.octavia.base_iface | ||
| targets: | ||
| - select: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-2 | ||
| fieldPaths: | ||
| - spec.desiredState.interfaces.[name=octavia].vlan.base-iface | ||
| - source: | ||
| kind: ConfigMap | ||
| name: octavia-network-values | ||
| fieldPath: data.octavia.vlan | ||
| targets: | ||
| - select: | ||
| kind: NodeNetworkConfigurationPolicy | ||
| labelSelector: osp/nncp-node=node-2 | ||
| fieldPaths: | ||
| - spec.desiredState.interfaces.[name=octavia].vlan.id |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Octavia replacement blocks in this file and
examples/va/multi-namespace-skmo/control-plane2/kustomization.yamlare identical. While not a blocking issue, it might be cleaner if that config could be extracted to a higher-level commonkustomization.yamlthat both sub-dirs could then include as a resource/component. In fact, it could be placed inva/multi-namespace-skmoand moved out ofexamplesentirely, which would make the inclusion cleaner too.