Skip to content

Add octavia service to SKMO central and leaf regions#759

Open
vakwetu wants to merge 1 commit into
openstack-k8s-operators:mainfrom
vakwetu:add-octavia-to-skmo
Open

Add octavia service to SKMO central and leaf regions#759
vakwetu wants to merge 1 commit into
openstack-k8s-operators:mainfrom
vakwetu:add-octavia-to-skmo

Conversation

@vakwetu

@vakwetu vakwetu commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add OVN Octavia networking for SKMO multi-region deployment
Compose SKMO overlays on multi-namespace bases with small components for
Octavia NNCP, EDPM octbr bridge mappings, and network-values patches.
NNCP stages reuse base values.yaml templates; octavia-network-values
component keeps kustomize load-restrictor-safe paths for CI kustomize_deploy.

Signed-off-by: Ade Lee alee@redhat.com
Assisted-by: Claude Sonnet 4.6 noreply@anthropic.com

@openshift-ci openshift-ci Bot requested review from abays and leifmadsen May 14, 2026 23:23
@openshift-ci

openshift-ci Bot commented May 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vakwetu
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vakwetu vakwetu requested review from fultonj and removed request for abays and leifmadsen May 14, 2026 23:23
@vakwetu vakwetu requested review from beagles and gthiemonge May 14, 2026 23:26
@vakwetu

vakwetu commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

hey @beagles and @gthiemonge . I'm adding octavia to the skmo ci job. Still testing - but can you confirm I've done everything I need to do. Thanks.

@vakwetu vakwetu force-pushed the add-octavia-to-skmo branch 2 times, most recently from 424a81b to e9471c4 Compare May 26, 2026 18:31
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#3965 is needed.

@fultonj

fultonj commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

I'd like to hear from the octavia experts on this patch first.

@fultonj

fultonj commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Waiting for octavia experts to review

@gthiemonge

gthiemonge commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 8, 2026
@abays

abays commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

recheck

Logs for old failure no longer exist. Let's try again and review logs if necessary.

@abays

abays commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

If @vakwetu is satisfied with testing, LGTM

@vakwetu vakwetu force-pushed the add-octavia-to-skmo branch from e9471c4 to a20043c Compare June 8, 2026 22:12
vakwetu added a commit to vakwetu/ci-framework that referenced this pull request Jun 8, 2026
@vakwetu
Add SKMO OVN Octavia Tempest support for leaf region
9c05293 
Add EDPM recreate hook and extend network-values templates for Octavia
NAD generation. Leaf-region Tempest config lives in ci-framework-jobs
05-tests.yaml; reproducer uses post_tests: [] like the uni job.

Depends-On: openstack-k8s-operators/architecture#759

Signed-off-by: Ade Lee <alee@redhat.com>
Assisted-by: Claude Opus 4.6
@openshift-ci openshift-ci Bot removed the lgtm label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/7c321be332614987b0860e7e422d6d66

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-multi-namespace-skmo FAILURE in 5m 00s

@vakwetu vakwetu force-pushed the add-octavia-to-skmo branch from a20043c to 90d5ca6 Compare June 9, 2026 01:41
@vakwetu vakwetu force-pushed the add-octavia-to-skmo branch from 90d5ca6 to fcec73d Compare June 9, 2026 01:58
@vakwetu vakwetu mentioned this pull request Jun 9, 2026
Open
@vakwetu vakwetu force-pushed the add-octavia-to-skmo branch from fcec73d to c996522 Compare June 9, 2026 02:05
vakwetu added a commit to vakwetu/ci-framework that referenced this pull request Jun 9, 2026
@vakwetu
[ci_gen_kustomize_values] Add SKMO OVN Octavia Tempest support for le…
f1da49a 
…af region

Add EDPM recreate hook and extend network-values templates for Octavia
NAD generation. Leaf-region Tempest config lives in ci-framework-jobs
05-tests.yaml; reproducer uses post_tests: [] like the uni job.

Depends-On: openstack-k8s-operators/architecture#759

Signed-off-by: Ade Lee <alee@redhat.com>
Assisted-by: Claude Opus 4.6
@vakwetu vakwetu force-pushed the add-octavia-to-skmo branch from c996522 to 96ad0e9 Compare June 12, 2026 20:17
@Deydra71 Deydra71 force-pushed the add-octavia-to-skmo branch from 96ad0e9 to 4ec2613 Compare June 17, 2026 10:22
@Deydra71

Deydra71 commented Jun 17, 2026

Copy link
Copy Markdown

Rebased so test project can run with the latest changes

@abays

abays commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@Deydra71 Did a testproject run for this?

@Deydra71

Deydra71 commented Jun 22, 2026

Copy link
Copy Markdown

@abays it did, but not successfully yet. Tho it's failing on federation part after successfully configuring Octavia. There's currently a federation bug that's being fixed --> openstack-k8s-operators/ci-framework#4006 so if we want full test project run we need to wait a bit

abays
abays reviewed Jun 22, 2026
View reviewed changes
Comment thread va/multi-namespace-skmo/networking-octavia/kustomization.yaml Outdated
kind: Component

components:
- ../../../examples/va/multi-namespace-skmo/components/octavia-network-values

@abays abays Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an anti-pattern in regards to the architecture repo layout. Rather than this kustomizaton.yaml depending on the values from the examples dir, the ../../../examples/va/multi-namespace-skmo/components/octavia-network-values/kustomization.yaml file should depend on this dir (va/multi-namespace-skmo/networking-octavia) and should include its own octavia-network-values.yaml in its list of resources.

abays
abays reviewed Jun 22, 2026
View reviewed changes
Comment thread examples/va/multi-namespace-skmo/control-plane/kustomization.yaml

@abays abays Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Octavia replacement blocks in this file and examples/va/multi-namespace-skmo/control-plane2/kustomization.yaml are identical. While not a blocking issue, it might be cleaner if that config could be extracted to a higher-level common kustomization.yaml that both sub-dirs could then include as a resource/component. In fact, it could be placed in va/multi-namespace-skmo and moved out of examples entirely, which would make the inclusion cleaner too.

@Deydra71 Deydra71 force-pushed the add-octavia-to-skmo branch 2 times, most recently from 0bd85f7 to a9c9641 Compare June 22, 2026 15:35
@vakwetu @Deydra71
Add Octavia support for SKMO multi-namespace deployment
6da0165 
Add reusable va/ components for Octavia:
- networking-octavia: NetConfig skeleton and NAD replacements
- octavia-network-values: dedicated ConfigMap with network parameters
- octavia-service-values: dedicated ConfigMap with service parameters
- octavia-controlplane: shared OSCP replacements (service config, images,
  network attachments, OVN nicMappings, CA passphrase secret)

Wire Octavia into examples/va/multi-namespace-skmo: control-plane networking
(NAD, NetConfig, NNCP), EDPM bridge mapping, and MetalLB ctlplane bridge
patch. Dependency flow is examples/ -> va/ (no reverse references).

Signed-off-by: Ade Lee <alee@redhat.com>
Assisted-by: Claude Opus 4.6
@Deydra71 Deydra71 force-pushed the add-octavia-to-skmo branch from a9c9641 to 6da0165 Compare June 23, 2026 14:22
@Deydra71

Deydra71 commented Jun 23, 2026

Copy link
Copy Markdown

Had to move octavia-ca-passphrase Secret from secretGenerator in va/octavia-controlplane to a direct resource file in each control-plane directory so the NamespaceTransformer correctly sets the namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays left review comments

@fultonj fultonj Awaiting requested review from fultonj

@gthiemonge gthiemonge Awaiting requested review from gthiemonge

@beagles beagles Awaiting requested review from beagles

At least 1 approving review is required to merge this pull request.

Assignees

@gthiemonge gthiemonge

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vakwetu @fultonj @gthiemonge @abays @Deydra71