Repository navigation
Let a migration defer itself without stopping the update - #601
Merged
Merged
Conversation
A migration that exits 75 changed nothing and cannot finish yet: omarchy-migrate leaves it pending with its login notification, runs the migrations after it and exits 0, so omarchy update carries on. Any other failure still stops the queue. The platform migration passes a deferred refusal of its entrypoint through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket 53, owner decision 2: the generic "deferred" migration result, mirrored from the commit added to omacom#13362 (eebfbc0 on
upstream/convergence).A migration that exits 75 (EX_TEMPFAIL) changed nothing and cannot finish yet.
omarchy-migrateleaves it pending with its login notification, runs the migrations after it and exits 0, soomarchy updatecarries on; the next update or login retries it. Any other failure still stops the queue with its status.migrations/1790347292.shpasses a deferred refusal of its entrypoint through. The migrations guide, file layout and lifecycle dispatch docs say so.Tests: new
test/shell.d/migrate-deferred-test.sh(deferred stays pending with notification while later ones run, retried every run, other statuses still stop the queue);platform-migration-test.shgains the 75 pass-through. Ran migrate-deferred, migrate-wrapper, migrate-notify, migrate-scope, platform-migration and bin-style in an Arch container; the full runtime suite on the upstream branch shows only the failures its base already has in that container (pkgs checkout, mise, namespaces).Second review: no findings on this part.