Repository navigation
Read the Apple package list by either name - #28
Merged
Merged
Conversation
Upstream names the Apple list omarchy-apple-silicon.packages, after the platform; quattro-upstream still ships omarchy-apple.packages. The builder reads whichever list the candidate runtime ships, preferring upstream's name and passing over a link, which bsdtar reads as empty. It reads the list once, before the images exist, and stops on a runtime with no list or an empty one. The importer takes the same list for its add-on and boot package check, and the inspection now checks that every package the image's Apple list names is installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream's convergence (omacom/omarchy#13362, next batch) names the Apple list
omarchy-apple-silicon.packages; quattro-upstream shipsomarchy-apple.packagestoday. The builder, the importer and the inspection now take whichever list the candidate runtime ships, preferring the new name, the same way #25 handled the pacman templates.apple-packages: every package the image's Apple list names is installed.Tested:
bash image-builder/test/allandbash test/all(Bash 5) pass. New cases cover the new name, the old name, both, a compatibility link either way, neither, a link only, and an empty list, in the builder, importer and inspection tests.Second review: no defects; wording nits applied on the omarchy-mac side.